Re: [dm-devel] [PATCH v2 1/2] dm: verity support data device offset (Linux 3.4.7)

2012-08-09 Thread Wesley Miaw
On Aug 8, 2012, at 7:04 PM, Alasdair G Kergon wrote: > > However, first you need to address the second part of Mikulas's email, > namely to make the case for these changes rather than making no kernel > changes and instead stacking the verity target over a linear target. > > To put this another

Re: [dm-devel] [PATCH v2 1/2] dm: verity support data device offset (Linux 3.4.7)

2012-08-09 Thread Wesley Miaw
On Aug 8, 2012, at 7:04 PM, Alasdair G Kergon wrote: However, first you need to address the second part of Mikulas's email, namely to make the case for these changes rather than making no kernel changes and instead stacking the verity target over a linear target. To put this another way,

Re: [dm-devel] [PATCH v2 1/2] dm: verity support data device offset (Linux 3.4.7)

2012-08-08 Thread Alasdair G Kergon
On Thu, Aug 09, 2012 at 12:40:22AM +, Wesley Miaw wrote: > Apologies if the version increment is incorrect; I was not sure if the minor > or patch number should be incremented. I assume the different version number > is > what would be used to detect if the data offset option is supported.

Re: [dm-devel] [PATCH v2 1/2] dm: verity support data device offset (Linux 3.4.7)

2012-08-08 Thread Wesley Miaw
On Aug 8, 2012, at 1:31 PM, Milan Broz wrote: > On 08/08/2012 08:46 PM, Mikulas Patocka wrote: > >> The problem with the patch is that it changes interface to the userspace >> tool. The userspace tool veritysetup already exists in recent cryptsetup >> package, so we can't change the interface

Re: [dm-devel] [PATCH v2 1/2] dm: verity support data device offset (Linux 3.4.7)

2012-08-08 Thread Wesley Miaw
On Aug 8, 2012, at 1:31 PM, Milan Broz wrote: On 08/08/2012 08:46 PM, Mikulas Patocka wrote: The problem with the patch is that it changes interface to the userspace tool. The userspace tool veritysetup already exists in recent cryptsetup package, so we can't change the interface - you

Re: [dm-devel] [PATCH v2 1/2] dm: verity support data device offset (Linux 3.4.7)

2012-08-08 Thread Alasdair G Kergon
On Thu, Aug 09, 2012 at 12:40:22AM +, Wesley Miaw wrote: Apologies if the version increment is incorrect; I was not sure if the minor or patch number should be incremented. I assume the different version number is what would be used to detect if the data offset option is supported.