Re: [dm-devel] [PATCH v3 04/26] block: Refactor blk_update_request()

2012-10-02 Thread Kent Overstreet
On Tue, Oct 02, 2012 at 04:14:51PM -0400, Vivek Goyal wrote: > On Tue, Oct 02, 2012 at 01:10:14PM -0700, Kent Overstreet wrote: > > On Tue, Oct 02, 2012 at 02:43:59PM -0400, Vivek Goyal wrote: > > > On Mon, Sep 24, 2012 at 03:34:44PM -0700, Kent Overstreet wrote: > > > > Converts it to use bio_adva

Re: [dm-devel] [PATCH v3 04/26] block: Refactor blk_update_request()

2012-10-02 Thread Vivek Goyal
On Tue, Oct 02, 2012 at 01:10:14PM -0700, Kent Overstreet wrote: > On Tue, Oct 02, 2012 at 02:43:59PM -0400, Vivek Goyal wrote: > > On Mon, Sep 24, 2012 at 03:34:44PM -0700, Kent Overstreet wrote: > > > Converts it to use bio_advance(), simplifying it quite a bit in the > > > process. > > > > > >

Re: [dm-devel] [PATCH v3 04/26] block: Refactor blk_update_request()

2012-10-02 Thread Kent Overstreet
On Tue, Oct 02, 2012 at 02:43:59PM -0400, Vivek Goyal wrote: > On Mon, Sep 24, 2012 at 03:34:44PM -0700, Kent Overstreet wrote: > > Converts it to use bio_advance(), simplifying it quite a bit in the > > process. > > > > Note that req_bio_endio() now always calls bio_advance() - which means > > it

Re: [dm-devel] [PATCH v3 04/26] block: Refactor blk_update_request()

2012-10-02 Thread Kent Overstreet
On Tue, Oct 02, 2012 at 02:59:55PM -0400, Vivek Goyal wrote: > On Mon, Sep 24, 2012 at 03:34:44PM -0700, Kent Overstreet wrote: > > Converts it to use bio_advance(), simplifying it quite a bit in the > > process. > > > > Note that req_bio_endio() now always calls bio_advance() - which means > > it

Re: [dm-devel] [PATCH v3 04/26] block: Refactor blk_update_request()

2012-10-02 Thread Vivek Goyal
On Mon, Sep 24, 2012 at 03:34:44PM -0700, Kent Overstreet wrote: > Converts it to use bio_advance(), simplifying it quite a bit in the > process. > > Note that req_bio_endio() now always calls bio_advance() - which means > it always loops over the biovec, not just on partial completions. Don't > e

Re: [dm-devel] [PATCH v3 04/26] block: Refactor blk_update_request()

2012-10-02 Thread Vivek Goyal
On Mon, Sep 24, 2012 at 03:34:44PM -0700, Kent Overstreet wrote: > Converts it to use bio_advance(), simplifying it quite a bit in the > process. > > Note that req_bio_endio() now always calls bio_advance() - which means > it always loops over the biovec, not just on partial completions. Don't > e