Re: [draft] Blackfin Early Printk implmentation

2007-08-18 Thread Robin Getz
On Sat 18 Aug 2007 02:23, Sam Ravnborg pondered: > > > What was preventing you from just using the x86_64 code here? > > > > Some was borrowed - but not much. since we don't support vga, or > > 16550 UARTs (Blackfin has it's own on-chip UART), I don't think > > this would work. Everyone impleme

Re: [draft] Blackfin Early Printk implmentation

2007-08-17 Thread Sam Ravnborg
> > What was preventing you from just using the x86_64 code here? > > Some was borrowed - but not much. since we don't support vga, or 16550 UARTs > (Blackfin has it's own on-chip UART), I don't think this would work. > > Maybe I'm missing something - but I don't think so. Every one who implemen

Re: [draft] Blackfin Early Printk implmentation

2007-08-17 Thread Robin Getz
On Fri 17 Aug 2007 13:59, Sam Ravnborg pondered: > That seems to explain why I could not follow your code changes. > A more fine grained splitup would have helped here. Sorry - see below. These aren't proper patches anymore, since it was faster for me to split them by hand (but should be OK for re

Re: [draft] Blackfin Early Printk implmentation

2007-08-17 Thread Mike Frysinger
On 8/17/07, Robin Getz <[EMAIL PROTECTED]> wrote: > On Fri 17 Aug 2007 13:57, Mike Frysinger pondered: > > On 8/17/07, Robin Getz <[EMAIL PROTECTED]> wrote: > > > +int __init disable_early_printk(void) > > > +{ > > > + if (!early_console_initialized) > > > + return 0; > > > + >

Re: [draft] Blackfin Early Printk implmentation

2007-08-17 Thread Robin Getz
On Fri 17 Aug 2007 13:57, Mike Frysinger pondered: > On 8/17/07, Robin Getz <[EMAIL PROTECTED]> wrote: > > +int __init disable_early_printk(void) > > +{ > > + if (!early_console_initialized) > > + return 0; > > + > > + printk(KERN_INFO "Unregister %s%d\n", early_console_i

Re: [draft] Blackfin Early Printk implmentation

2007-08-17 Thread Sam Ravnborg
On Fri, Aug 17, 2007 at 01:36:39PM -0400, Robin Getz wrote: > The patch (for review - not inclusion - I will send to Bryan if no one has > any > major objections, and he can push it via git) implements early printk for the > Blackfin architecture. > > It also adds an early exception handler, so

Re: [draft] Blackfin Early Printk implmentation

2007-08-17 Thread Mike Frysinger
On 8/17/07, Robin Getz <[EMAIL PROTECTED]> wrote: > + asm("\tRETI = %0;\n" > + "\tRETX = %0;\n" > + "\tRETN = %0;\n" > + : : "p"(early_trap)); general note, i dont think inserting whitespace by hand in asm() is a good thing ... i see it as whitenoise personally

[draft] Blackfin Early Printk implmentation

2007-08-17 Thread Robin Getz
The patch (for review - not inclusion - I will send to Bryan if no one has any major objections, and he can push it via git) implements early printk for the Blackfin architecture. It also adds an early exception handler, so if an interrupt/exception/violation happens before the kernel enables i