Re: [f2fs-dev] [PATCH] f2fs: compress: Avoid memory leak on cc->cpages

2020-07-20 Thread Markus Elfring
>>> Memory allocated for storing compressed pages' poitner should be >>> released after f2fs_write_compressed_pages(), otherwise it will >>> cause memory leak issue. >> >> * Would an imperative wording be more appropriate (without a typo) >>   for the change description? >> >> * Will the tag “Fixes

Re: [f2fs-dev] [PATCH] f2fs: compress: Avoid memory leak on cc->cpages

2020-07-20 Thread Chao Yu
On 2020/7/20 19:31, Markus Elfring wrote: Memory allocated for storing compressed pages' poitner should be released after f2fs_write_compressed_pages(), otherwise it will cause memory leak issue. * Would an imperative wording be more appropriate (without a typo) for the change description?

Re: [f2fs-dev] [PATCH] f2fs: compress: Avoid memory leak on cc->cpages

2020-07-20 Thread Markus Elfring
> Memory allocated for storing compressed pages' poitner should be > released after f2fs_write_compressed_pages(), otherwise it will > cause memory leak issue. * Would an imperative wording be more appropriate (without a typo) for the change description? * Will the tag “Fixes” become helpful fo