> Actually, we didn't change priority of discard command, so that it is still
> synchronous IO for I/O scheduler, hence I/O interference will still exist if
> we
> try to issue discard without IO aware ability.
> Of course we can change the priority of discard command to lower, but
> potential
On 2017/9/12 12:34, Daeho Jeong wrote:
>> Yeah, that's exactly like what I made a mistake before.
>> I should have mentioned that earlier. :)
>
> Or I think the previous code which used "iter++" might be right.
> You might just want to check the fixed number of small discards,
> DISCARD_ISSUE_RAT
On 09/12, Daeho Jeong wrote:
> > Yeah, that's exactly like what I made a mistake before.
> > I should have mentioned that earlier. :)
>
> Or I think the previous code which used "iter++" might be right.
> You might just want to check the fixed number of small discards,
> DISCARD_ISSUE_RATE,
> whe
> Yeah, that's exactly like what I made a mistake before.
> I should have mentioned that earlier. :)
Or I think the previous code which used "iter++" might be right.
You might just want to check the fixed number of small discards,
DISCARD_ISSUE_RATE,
when issue_cond is "true".
Anyways, I have an
On 09/12, Chao Yu wrote:
> On 2017/9/12 9:53, Chao Yu wrote:
> > On 2017/9/11 11:38, Jaegeuk Kim wrote:
> >> If issue_cond is true, it does double count for # of issued commands.
> >>
> >> Signed-off-by: Jaegeuk Kim
> >
> > Reviewed-by: Chao Yu
>
> As Daeho Jeong mentioned, the change makes 'it
On 2017/9/12 9:53, Chao Yu wrote:
> On 2017/9/11 11:38, Jaegeuk Kim wrote:
>> If issue_cond is true, it does double count for # of issued commands.
>>
>> Signed-off-by: Jaegeuk Kim
>
> Reviewed-by: Chao Yu
As Daeho Jeong mentioned, the change makes 'iter > DISCARD_ISSUE_RATE' dead
code, I just
On 2017/9/11 11:38, Jaegeuk Kim wrote:
> If issue_cond is true, it does double count for # of issued commands.
>
> Signed-off-by: Jaegeuk Kim
Reviewed-by: Chao Yu
> ---
> fs/f2fs/segment.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/f2fs/segment.c b/fs/f2fs/se
7 matches
Mail list logo
