RE: [f2fs-dev] [PATCH] f2fs: readahead contiguous pages for restore_node_summary

2013-11-29 Thread Jaegeuk Kim
Hi, [snip] > > > So how about add all pages of page list to node_inode's address space by > > > add_to_page_cache_lru() with arg sum_entry->nid? > > > > I don't think it's proper way to use add_to_page_cache_lru() directly. > > This is the way used in VM readahead(i.e. read_pages/mpage_readpages

RE: [f2fs-dev] [PATCH] f2fs: readahead contiguous pages for restore_node_summary

2013-11-27 Thread Chao Yu
gt; > Sent: Wednesday, November 27, 2013 4:19 PM > > > To: Chao Yu > > > Cc: linux-fsde...@vger.kernel.org; linux-kernel@vger.kernel.org; > > > linux-f2fs-de...@lists.sourceforge.net; '谭姝' > > > Subject: RE: [f2fs-dev] [PATCH] f2fs: readahea

RE: [f2fs-dev] [PATCH] f2fs: readahead contiguous pages for restore_node_summary

2013-11-27 Thread Jaegeuk Kim
@vger.kernel.org; > > linux-f2fs-de...@lists.sourceforge.net; '谭姝' > > Subject: RE: [f2fs-dev] [PATCH] f2fs: readahead contiguous pages for > > restore_node_summary > > > > Hi, > > > > 2013-11-27 (수), 15:58 +0800, Chao Yu: > > > Hi Kim, &

RE: [f2fs-dev] [PATCH] f2fs: readahead contiguous pages for restore_node_summary

2013-11-27 Thread Chao Yu
> > > Sent: Wednesday, November 27, 2013 1:30 PM > > > To: Chao Yu > > > Cc: linux-fsde...@vger.kernel.org; linux-kernel@vger.kernel.org; > > > linux-f2fs-de...@lists.sourceforge.net; 谭姝 > > > Subject: Re: [f2fs-dev] [PATCH] f2fs: readahead contiguous pag

RE: [f2fs-dev] [PATCH] f2fs: readahead contiguous pages for restore_node_summary

2013-11-27 Thread Jaegeuk Kim
@vger.kernel.org; > > linux-f2fs-de...@lists.sourceforge.net; 谭姝 > > Subject: Re: [f2fs-dev] [PATCH] f2fs: readahead contiguous pages for > > restore_node_summary > > > > Hi Chao, > > > > It seems that we already have a readahed function for node pages, &

RE: [f2fs-dev] [PATCH] f2fs: readahead contiguous pages for restore_node_summary

2013-11-27 Thread Chao Yu
Re: [f2fs-dev] [PATCH] f2fs: readahead contiguous pages for > restore_node_summary > > Hi Chao, > > It seems that we already have a readahed function for node pages, > ra_node_page(). > So, we don't make a page list for this, but can use the node_inode's > page c

Re: [f2fs-dev] [PATCH] f2fs: readahead contiguous pages for restore_node_summary

2013-11-26 Thread Jaegeuk Kim
Hi Chao, It seems that we already have a readahed function for node pages, ra_node_page(). So, we don't make a page list for this, but can use the node_inode's page cache. So how about writing ra_node_pages() which use the node_inode's page cache? Thanks, 2013-11-22 (금), 15:48 +0800, Chao Yu: >

[f2fs-dev] [PATCH] f2fs: readahead contiguous pages for restore_node_summary

2013-11-21 Thread Chao Yu
If cp has no CP_UMOUNT_FLAG, we will read all pages in whole node segment one by one, it makes low performance. So let's merge contiguous pages and readahead for better performance. Signed-off-by: Chao Yu --- fs/f2fs/node.c | 89 +++- 1 fil