.com
> Subject: Re: [f2fs-dev] [PATCH] f2fs: remove unneeded code in punch_hole
>
> Got it.
>
> But, with this patch, we can also remove the parameter, int mode, in
> punch_hole().
> If no objection, I'll fix that in your patch.
> Thanks,
Right, we should remove it.
Thank
Got it.
But, with this patch, we can also remove the parameter, int mode, in
punch_hole().
If no objection, I'll fix that in your patch.
Thanks,
2013-11-22 (금), 16:52 +0800, Chao Yu:
> Because FALLOC_FL_PUNCH_HOLE flag must be ORed with FALLOC_FL_KEEP_SIZE
> in fallocate, so we could remove the
Got it.
But, with this patch, we can also remove the parameter, int mode, in
punch_hole().
If no objection, I'll fix that in your patch.
Thanks,
2013-11-22 (금), 16:52 +0800, Chao Yu:
Because FALLOC_FL_PUNCH_HOLE flag must be ORed with FALLOC_FL_KEEP_SIZE
in fallocate, so we could remove the
-dev] [PATCH] f2fs: remove unneeded code in punch_hole
Got it.
But, with this patch, we can also remove the parameter, int mode, in
punch_hole().
If no objection, I'll fix that in your patch.
Thanks,
Right, we should remove it.
Thanks!
2013-11-22 (금), 16:52 +0800, Chao Yu:
Because
Because FALLOC_FL_PUNCH_HOLE flag must be ORed with FALLOC_FL_KEEP_SIZE
in fallocate, so we could remove the useless 'keep size' branch code which
will never be excuted in punch_hole.
Signed-off-by: Chao Yu
Signed-off-by: Fan Li
---
fs/f2fs/file.c |6 --
1 file changed, 6
Because FALLOC_FL_PUNCH_HOLE flag must be ORed with FALLOC_FL_KEEP_SIZE
in fallocate, so we could remove the useless 'keep size' branch code which
will never be excuted in punch_hole.
Signed-off-by: Chao Yu chao2...@samsung.com
Signed-off-by: Fan Li fanofcode...@samsung.com
---
fs/f2fs/file.c
6 matches
Mail list logo
