Re: [f2fs-dev] [PATCH 08/10] f2fs: relax async discard commands more

2017-02-22 Thread Jaegeuk Kim
On 02/23, Chao Yu wrote: > On 2017/2/23 5:15, Jaegeuk Kim wrote: > > On 02/22, Chao Yu wrote: > >> On 2017/1/6 10:42, Jaegeuk Kim wrote: > >>> Hi Chao, > >>> > >>> On 01/06, Chao Yu wrote: > On 2017/1/6 3:46, Jaegeuk Kim wrote: > > On 01/05, Chao Yu wrote: > >> On 2017/1/4 17:29, Chao

Re: [f2fs-dev] [PATCH 08/10] f2fs: relax async discard commands more

2017-02-22 Thread Chao Yu
On 2017/2/23 5:15, Jaegeuk Kim wrote: > On 02/22, Chao Yu wrote: >> On 2017/1/6 10:42, Jaegeuk Kim wrote: >>> Hi Chao, >>> >>> On 01/06, Chao Yu wrote: On 2017/1/6 3:46, Jaegeuk Kim wrote: > On 01/05, Chao Yu wrote: >> On 2017/1/4 17:29, Chao Yu wrote: >>> On 2016/12/31 2:51, Jaege

Re: [f2fs-dev] [PATCH 08/10] f2fs: relax async discard commands more

2017-02-22 Thread Jaegeuk Kim
On 02/22, Chao Yu wrote: > On 2017/1/6 10:42, Jaegeuk Kim wrote: > > Hi Chao, > > > > On 01/06, Chao Yu wrote: > >> On 2017/1/6 3:46, Jaegeuk Kim wrote: > >>> On 01/05, Chao Yu wrote: > On 2017/1/4 17:29, Chao Yu wrote: > > On 2016/12/31 2:51, Jaegeuk Kim wrote: > >> This patch relaxe

Re: [f2fs-dev] [PATCH 08/10] f2fs: relax async discard commands more

2017-02-21 Thread Chao Yu
On 2017/1/6 10:42, Jaegeuk Kim wrote: > Hi Chao, > > On 01/06, Chao Yu wrote: >> On 2017/1/6 3:46, Jaegeuk Kim wrote: >>> On 01/05, Chao Yu wrote: On 2017/1/4 17:29, Chao Yu wrote: > On 2016/12/31 2:51, Jaegeuk Kim wrote: >> This patch relaxes async discard commands to avoid waiting i

Re: [f2fs-dev] [PATCH 08/10] f2fs: relax async discard commands more

2017-01-05 Thread Chao Yu
Hi Jaegeuk, On 2017/1/6 10:42, Jaegeuk Kim wrote: > Hi Chao, > > On 01/06, Chao Yu wrote: >> On 2017/1/6 3:46, Jaegeuk Kim wrote: >>> On 01/05, Chao Yu wrote: On 2017/1/4 17:29, Chao Yu wrote: > On 2016/12/31 2:51, Jaegeuk Kim wrote: >> This patch relaxes async discard commands to av

Re: [f2fs-dev] [PATCH 08/10] f2fs: relax async discard commands more

2017-01-05 Thread Jaegeuk Kim
Hi Chao, On 01/06, Chao Yu wrote: > On 2017/1/6 3:46, Jaegeuk Kim wrote: > > On 01/05, Chao Yu wrote: > >> On 2017/1/4 17:29, Chao Yu wrote: > >>> On 2016/12/31 2:51, Jaegeuk Kim wrote: > This patch relaxes async discard commands to avoid waiting its end_io > during > checkpoint. >

Re: [f2fs-dev] [PATCH 08/10] f2fs: relax async discard commands more

2017-01-05 Thread Chao Yu
On 2017/1/6 3:46, Jaegeuk Kim wrote: > On 01/05, Chao Yu wrote: >> On 2017/1/4 17:29, Chao Yu wrote: >>> On 2016/12/31 2:51, Jaegeuk Kim wrote: This patch relaxes async discard commands to avoid waiting its end_io during checkpoint. Instead of waiting them during checkpoint, it

Re: [f2fs-dev] [PATCH 08/10] f2fs: relax async discard commands more

2017-01-05 Thread Jaegeuk Kim
Hi Chao, On 01/05, Chao Yu wrote: > Hi Jaegeuk, > > I can see patch named ("f2fs: call f2fs_wait_all_discard_bio for an error > case") > was merged in dev-test, but I think it's no needed to change error case > handling > like this since f2fs_wait_all_discard_bio should always be called after >

Re: [f2fs-dev] [PATCH 08/10] f2fs: relax async discard commands more

2017-01-05 Thread Jaegeuk Kim
On 01/05, Chao Yu wrote: > On 2017/1/4 17:29, Chao Yu wrote: > > On 2016/12/31 2:51, Jaegeuk Kim wrote: > >> This patch relaxes async discard commands to avoid waiting its end_io > >> during > >> checkpoint. > >> Instead of waiting them during checkpoint, it will be done when actually > >> reusin

Re: [f2fs-dev] [PATCH 08/10] f2fs: relax async discard commands more

2017-01-05 Thread Chao Yu
Hi Jaegeuk, I can see patch named ("f2fs: call f2fs_wait_all_discard_bio for an error case") was merged in dev-test, but I think it's no needed to change error case handling like this since f2fs_wait_all_discard_bio should always be called after clear_prefree_segments. Thanks, On 2017/1/5 11:19,

Re: [f2fs-dev] [PATCH 08/10] f2fs: relax async discard commands more

2017-01-04 Thread Chao Yu
On 2017/1/4 17:29, Chao Yu wrote: > On 2016/12/31 2:51, Jaegeuk Kim wrote: >> This patch relaxes async discard commands to avoid waiting its end_io during >> checkpoint. >> Instead of waiting them during checkpoint, it will be done when actually >> reusing >> them. >> >> Test on initial partition

Re: [f2fs-dev] [PATCH 08/10] f2fs: relax async discard commands more

2017-01-04 Thread Chao Yu
On 2016/12/31 2:51, Jaegeuk Kim wrote: > This patch relaxes async discard commands to avoid waiting its end_io during > checkpoint. > Instead of waiting them during checkpoint, it will be done when actually > reusing > them. > > Test on initial partition of nvme drive. > > # time fstrim /mnt/te