Re: [f2fs-dev] [PATCH 5/5] f2fs: enforce fsync_mode=strict for renamed directory

2018-04-26 Thread Chao Yu
On 2018/4/26 23:32, Jaegeuk Kim wrote: > On 04/25, Chao Yu wrote: >> On 2018/4/25 13:46, Jaegeuk Kim wrote: >>> This is to give a option for user to be able to recover B/foo in the below >>> case. >>> >>> mkdir A >>> sync() >>> rename(A, B) >>> creat (B/foo) >>> fsync (B/foo) >>> ---crash--- >> >>

Re: [f2fs-dev] [PATCH 5/5] f2fs: enforce fsync_mode=strict for renamed directory

2018-04-26 Thread Jaegeuk Kim
On 04/25, Chao Yu wrote: > On 2018/4/25 13:46, Jaegeuk Kim wrote: > > This is to give a option for user to be able to recover B/foo in the below > > case. > > > > mkdir A > > sync() > > rename(A, B) > > creat (B/foo) > > fsync (B/foo) > > ---crash--- > > That makes sense, IMO, it will be better t

Re: [f2fs-dev] [PATCH 5/5] f2fs: enforce fsync_mode=strict for renamed directory

2018-04-25 Thread Chao Yu
On 2018/4/25 13:46, Jaegeuk Kim wrote: > This is to give a option for user to be able to recover B/foo in the below > case. > > mkdir A > sync() > rename(A, B) > creat (B/foo) > fsync (B/foo) > ---crash--- That makes sense, IMO, it will be better to cover cross rename case as well? Thanks, > >