Re: [f2fs-dev] [PATCH v3] f2fs: avoid race condition for shinker count

2020-12-03 Thread Chao Yu
On 2020/12/3 15:55, Jaegeuk Kim wrote: How about adding another variable to monitor it? That makes more sense. :) I've checked this, LGTM. Reviewed-by: Chao Yu Thanks, From bdc5a805487f0210df7ef4e85ce5a4f0471bca72 Mon Sep 17 00:00:00 2001 From: Jaegeuk Kim Date: Fri, 6 Nov 2020 13:22:0

Re: [f2fs-dev] [PATCH v3] f2fs: avoid race condition for shinker count

2020-12-03 Thread Jaegeuk Kim
On 12/03, Chao Yu wrote: > On 2020/12/3 14:07, Jaegeuk Kim wrote: > > On 11/11, Jaegeuk Kim wrote: > > > Light reported sometimes shinker gets nat_cnt < dirty_nat_cnt resulting in > > > wrong do_shinker work. Let's avoid to get stale data by using > > > nat_tree_lock. > > > > > > Reported-by: Lig

Re: [f2fs-dev] [PATCH v3] f2fs: avoid race condition for shinker count

2020-12-02 Thread Chao Yu
On 2020/12/3 14:07, Jaegeuk Kim wrote: On 11/11, Jaegeuk Kim wrote: Light reported sometimes shinker gets nat_cnt < dirty_nat_cnt resulting in wrong do_shinker work. Let's avoid to get stale data by using nat_tree_lock. Reported-by: Light Hsieh Signed-off-by: Jaegeuk Kim --- v3: - fix to us

Re: [f2fs-dev] [PATCH v3] f2fs: avoid race condition for shinker count

2020-12-02 Thread Jaegeuk Kim
On 11/11, Jaegeuk Kim wrote: > Light reported sometimes shinker gets nat_cnt < dirty_nat_cnt resulting in > wrong do_shinker work. Let's avoid to get stale data by using nat_tree_lock. > > Reported-by: Light Hsieh > Signed-off-by: Jaegeuk Kim > --- > v3: > - fix to use NM_I(sbi) > > fs/f2fs/s

Re: [f2fs-dev] [PATCH v3] f2fs: avoid race condition for shinker count

2020-11-17 Thread Jaegeuk Kim
On 11/12, Chao Yu wrote: > On 2020/11/12 13:40, Jaegeuk Kim wrote: > > Light reported sometimes shinker gets nat_cnt < dirty_nat_cnt resulting in > > wrong do_shinker work. Let's avoid to get stale data by using nat_tree_lock. > > > > Reported-by: Light Hsieh > > Signed-off-by: Jaegeuk Kim > > -

Re: [f2fs-dev] [PATCH v3] f2fs: avoid race condition for shinker count

2020-11-11 Thread Chao Yu
On 2020/11/12 13:40, Jaegeuk Kim wrote: Light reported sometimes shinker gets nat_cnt < dirty_nat_cnt resulting in wrong do_shinker work. Let's avoid to get stale data by using nat_tree_lock. Reported-by: Light Hsieh Signed-off-by: Jaegeuk Kim --- v3: - fix to use NM_I(sbi) fs/f2fs/shrink

Re: [f2fs-dev] [PATCH v3] f2fs: avoid race condition for shinker count

2020-11-11 Thread Jaegeuk Kim
Light reported sometimes shinker gets nat_cnt < dirty_nat_cnt resulting in wrong do_shinker work. Let's avoid to get stale data by using nat_tree_lock. Reported-by: Light Hsieh Signed-off-by: Jaegeuk Kim --- v3: - fix to use NM_I(sbi) fs/f2fs/shrinker.c | 6 +- 1 file changed, 5 insertion