On 2020/12/8 9:26, Jaegeuk Kim wrote:
On 12/08, Chao Yu wrote:
On 2020/12/8 4:37, Eric Biggers wrote:
On Thu, Nov 26, 2020 at 06:32:09PM +0800, Chao Yu wrote:
+ if (!ret && fi->i_compress_flag & 1 << COMPRESS_CHKSUM) {
This really could use some parentheses. People shouldn't have to
On 12/08, Chao Yu wrote:
> On 2020/12/8 4:37, Eric Biggers wrote:
> > On Thu, Nov 26, 2020 at 06:32:09PM +0800, Chao Yu wrote:
> > > + if (!ret && fi->i_compress_flag & 1 << COMPRESS_CHKSUM) {
> >
> > This really could use some parentheses. People shouldn't have to look up a
> > C operator
On 2020/12/8 4:37, Eric Biggers wrote:
On Thu, Nov 26, 2020 at 06:32:09PM +0800, Chao Yu wrote:
+ if (!ret && fi->i_compress_flag & 1 << COMPRESS_CHKSUM) {
This really could use some parentheses. People shouldn't have to look up a
C operator precedence table to understand the code.
On Mon, 2020-12-07 at 12:37 -0800, Eric Biggers wrote:
> On Thu, Nov 26, 2020 at 06:32:09PM +0800, Chao Yu wrote:
> > + if (!ret && fi->i_compress_flag & 1 << COMPRESS_CHKSUM) {
>
> This really could use some parentheses. People shouldn't have to look up a
> C operator precedence table to
On Thu, Nov 26, 2020 at 06:32:09PM +0800, Chao Yu wrote:
> + if (!ret && fi->i_compress_flag & 1 << COMPRESS_CHKSUM) {
This really could use some parentheses. People shouldn't have to look up a
C operator precedence table to understand the code.
> + u32 provided =
5 matches
Mail list logo
