Re: [f2fs-dev] [PATCH v3] f2fs: rename checkpoint=merge mount option to checkpoint_merge

2021-02-02 Thread Chao Yu
On 2021/2/2 19:29, Daeho Jeong wrote: Thanks for the explanation. I am going to remove the line clearing "MERGE_CHECKPOINT". But, when we go with the below remount command, I think the "nocheckpoint_merge" option will work well to disable only just "checkpoint_merge" from the previous option. "m

Re: [f2fs-dev] [PATCH v3] f2fs: rename checkpoint=merge mount option to checkpoint_merge

2021-02-02 Thread Daeho Jeong
Thanks for the explanation. I am going to remove the line clearing "MERGE_CHECKPOINT". But, when we go with the below remount command, I think the "nocheckpoint_merge" option will work well to disable only just "checkpoint_merge" from the previous option. "mount -o remount,nocheckpoint_merge /dir

Re: [f2fs-dev] [PATCH v3] f2fs: rename checkpoint=merge mount option to checkpoint_merge

2021-02-02 Thread Chao Yu
On 2021/2/2 17:44, Daeho Jeong wrote: When we remount it without the "checkpoint_merge" option, shouldn't we need to clear "MERGE_CHECKPOINT" again? This is actually what I intended, but I was wrong. Actually, I found this. When we remount the filesystem, the previous mount option is passed thro

Re: [f2fs-dev] [PATCH v3] f2fs: rename checkpoint=merge mount option to checkpoint_merge

2021-02-02 Thread Daeho Jeong
When we remount it without the "checkpoint_merge" option, shouldn't we need to clear "MERGE_CHECKPOINT" again? This is actually what I intended, but I was wrong. Actually, I found this. When we remount the filesystem, the previous mount option is passed through the "data" argument in the below. f2

Re: [f2fs-dev] [PATCH v3] f2fs: rename checkpoint=merge mount option to checkpoint_merge

2021-02-02 Thread Chao Yu
On 2021/2/2 17:23, Daeho Jeong wrote: From: Daeho Jeong As checkpoint=merge comes in, mount option setting related to checkpoint had been mixed up and it became hard to understand. So, I separated this option from "checkpoint=" and made another mount option "checkpoint_merge" for this. Signed-