Re: [f2fs-dev] [PATCH v3 1/5] f2fs: compress: add compress_inode to cache compressed blocks

2021-01-28 Thread Chao Yu
On 2021/1/29 0:12, Jaegeuk Kim wrote: On 01/28, Chao Yu wrote: On 2021/1/22 10:17, Chao Yu wrote: No, it seems this is not the case. Oops, could you please help to remove all below codes and do the test again to check whether they are the buggy codes? as I doubt there is use-after-free bug.

Re: [f2fs-dev] [PATCH v3 1/5] f2fs: compress: add compress_inode to cache compressed blocks

2021-01-28 Thread Jaegeuk Kim
On 01/28, Chao Yu wrote: > On 2021/1/22 10:17, Chao Yu wrote: > > > No, it seems this is not the case. > > Oops, could you please help to remove all below codes and do the test again > > to check whether they are the buggy codes? as I doubt there is > > use-after-free > > bug. > > Any test

Re: [f2fs-dev] [PATCH v3 1/5] f2fs: compress: add compress_inode to cache compressed blocks

2021-01-27 Thread Chao Yu
On 2021/1/22 10:17, Chao Yu wrote: No, it seems this is not the case. Oops, could you please help to remove all below codes and do the test again to check whether they are the buggy codes? as I doubt there is use-after-free bug. Any test result? :) Thanks,

Re: [f2fs-dev] [PATCH v3 1/5] f2fs: compress: add compress_inode to cache compressed blocks

2021-01-21 Thread Chao Yu
On 2021/1/20 5:42, Jaegeuk Kim wrote: On 01/16, Chao Yu wrote: On 2021/1/15 22:59, Jaegeuk Kim wrote: On 01/15, Chao Yu wrote: On 2021/1/14 12:06, Jaegeuk Kim wrote: On 01/14, Chao Yu wrote: On 2021/1/13 23:41, Jaegeuk Kim wrote: [58690.961685] F2FS-fs (vdb) : inject page get in

Re: [f2fs-dev] [PATCH v3 1/5] f2fs: compress: add compress_inode to cache compressed blocks

2021-01-19 Thread Jaegeuk Kim
On 01/16, Chao Yu wrote: > On 2021/1/15 22:59, Jaegeuk Kim wrote: > > On 01/15, Chao Yu wrote: > > > On 2021/1/14 12:06, Jaegeuk Kim wrote: > > > > On 01/14, Chao Yu wrote: > > > > > On 2021/1/13 23:41, Jaegeuk Kim wrote: > > > > > > [58690.961685] F2FS-fs (vdb) : inject page get in > > > > > >

Re: [f2fs-dev] [PATCH v3 1/5] f2fs: compress: add compress_inode to cache compressed blocks

2021-01-16 Thread Chao Yu
On 2021/1/15 22:59, Jaegeuk Kim wrote: On 01/15, Chao Yu wrote: On 2021/1/14 12:06, Jaegeuk Kim wrote: On 01/14, Chao Yu wrote: On 2021/1/13 23:41, Jaegeuk Kim wrote: [58690.961685] F2FS-fs (vdb) : inject page get in f2fs_pagecache_get_page of f2fs_quota_write+0x150/0x1f0 [f2fs]

Re: [f2fs-dev] [PATCH v3 1/5] f2fs: compress: add compress_inode to cache compressed blocks

2021-01-15 Thread Jaegeuk Kim
On 01/15, Chao Yu wrote: > On 2021/1/14 12:06, Jaegeuk Kim wrote: > > On 01/14, Chao Yu wrote: > > > On 2021/1/13 23:41, Jaegeuk Kim wrote: > > > > [58690.961685] F2FS-fs (vdb) : inject page get in > > > > f2fs_pagecache_get_page of f2fs_quota_write+0x150/0x1f0 [f2fs] > > > > [58691.071481]

Re: [f2fs-dev] [PATCH v3 1/5] f2fs: compress: add compress_inode to cache compressed blocks

2021-01-15 Thread Chao Yu
On 2021/1/14 12:06, Jaegeuk Kim wrote: On 01/14, Chao Yu wrote: On 2021/1/13 23:41, Jaegeuk Kim wrote: [58690.961685] F2FS-fs (vdb) : inject page get in f2fs_pagecache_get_page of f2fs_quota_write+0x150/0x1f0 [f2fs] [58691.071481] F2FS-fs (vdb): Inconsistent error blkaddr:31058, sit bitmap:0

Re: [f2fs-dev] [PATCH v3 1/5] f2fs: compress: add compress_inode to cache compressed blocks

2021-01-13 Thread Jaegeuk Kim
On 01/14, Chao Yu wrote: > On 2021/1/13 23:41, Jaegeuk Kim wrote: > > [58690.961685] F2FS-fs (vdb) : inject page get in f2fs_pagecache_get_page > > of f2fs_quota_write+0x150/0x1f0 [f2fs] > > [58691.071481] F2FS-fs (vdb): Inconsistent error blkaddr:31058, sit bitmap:0 > > [58691.077338]

Re: [f2fs-dev] [PATCH v3 1/5] f2fs: compress: add compress_inode to cache compressed blocks

2021-01-13 Thread Chao Yu
On 2021/1/13 23:41, Jaegeuk Kim wrote: [58690.961685] F2FS-fs (vdb) : inject page get in f2fs_pagecache_get_page of f2fs_quota_write+0x150/0x1f0 [f2fs] [58691.071481] F2FS-fs (vdb): Inconsistent error blkaddr:31058, sit bitmap:0 [58691.077338] [ cut here ] [58691.081461]

Re: [f2fs-dev] [PATCH v3 1/5] f2fs: compress: add compress_inode to cache compressed blocks

2021-01-13 Thread Jaegeuk Kim
On 01/13, Chao Yu wrote: > On 2021/1/13 6:36, Jaegeuk Kim wrote: > > On 01/12, Chao Yu wrote: > > > On 2021/1/12 10:04, Jaegeuk Kim wrote: > > > > On 01/12, Chao Yu wrote: > > > > > On 2021/1/11 19:45, Chao Yu wrote: > > > > > > On 2021/1/11 18:31, Chao Yu wrote: > > > > > > > On 2021/1/11 17:48,

Re: [f2fs-dev] [PATCH v3 1/5] f2fs: compress: add compress_inode to cache compressed blocks

2021-01-12 Thread Chao Yu
On 2021/1/13 6:36, Jaegeuk Kim wrote: On 01/12, Chao Yu wrote: On 2021/1/12 10:04, Jaegeuk Kim wrote: On 01/12, Chao Yu wrote: On 2021/1/11 19:45, Chao Yu wrote: On 2021/1/11 18:31, Chao Yu wrote: On 2021/1/11 17:48, Jaegeuk Kim wrote: Hi Chao, After quick test of fsstress w/ fault

Re: [f2fs-dev] [PATCH v3 1/5] f2fs: compress: add compress_inode to cache compressed blocks

2021-01-12 Thread Jaegeuk Kim
On 01/12, Chao Yu wrote: > On 2021/1/12 10:04, Jaegeuk Kim wrote: > > On 01/12, Chao Yu wrote: > > > On 2021/1/11 19:45, Chao Yu wrote: > > > > On 2021/1/11 18:31, Chao Yu wrote: > > > > > On 2021/1/11 17:48, Jaegeuk Kim wrote: > > > > > > Hi Chao, > > > > > > > > > > > > After quick test of

Re: [f2fs-dev] [PATCH v3 1/5] f2fs: compress: add compress_inode to cache compressed blocks

2021-01-12 Thread Chao Yu
On 2021/1/12 10:04, Jaegeuk Kim wrote: On 01/12, Chao Yu wrote: On 2021/1/11 19:45, Chao Yu wrote: On 2021/1/11 18:31, Chao Yu wrote: On 2021/1/11 17:48, Jaegeuk Kim wrote: Hi Chao, After quick test of fsstress w/ fault injection, it gave wrong block address errors. Could you please run the

Re: [f2fs-dev] [PATCH v3 1/5] f2fs: compress: add compress_inode to cache compressed blocks

2021-01-11 Thread Jaegeuk Kim
On 01/12, Chao Yu wrote: > On 2021/1/11 19:45, Chao Yu wrote: > > On 2021/1/11 18:31, Chao Yu wrote: > > > On 2021/1/11 17:48, Jaegeuk Kim wrote: > > > > Hi Chao, > > > > > > > > After quick test of fsstress w/ fault injection, it gave wrong block > > > > address > > > > errors. Could you please

Re: [f2fs-dev] [PATCH v3 1/5] f2fs: compress: add compress_inode to cache compressed blocks

2021-01-11 Thread Chao Yu
On 2021/1/11 19:45, Chao Yu wrote: On 2021/1/11 18:31, Chao Yu wrote: On 2021/1/11 17:48, Jaegeuk Kim wrote: Hi Chao, After quick test of fsstress w/ fault injection, it gave wrong block address errors. Could you please run the test a bit? Jaegeuk, Oh, I've covered with fstest cases and

Re: [f2fs-dev] [PATCH v3 1/5] f2fs: compress: add compress_inode to cache compressed blocks

2021-01-11 Thread Chao Yu
On 2021/1/11 18:31, Chao Yu wrote: On 2021/1/11 17:48, Jaegeuk Kim wrote: Hi Chao, After quick test of fsstress w/ fault injection, it gave wrong block address errors. Could you please run the test a bit? Jaegeuk, Oh, I've covered with fstest cases and there is no such error message, let me