Re: [f2fs-dev] f2fs get_dnode_of_data oops

2014-09-10 Thread Jaegeuk Kim
On Tue, Sep 09, 2014 at 04:10:00PM +0800, Chao Yu wrote: > Hi Jaegeuk, > > Looks good to me! > > One nitpick, how about judging this condition before we lock ->i_mutex to > avoid unneeded lock contention and invoking of i_size_read()? Agreed. >From 0b4c5afde9b57c08b55d26725d228d5314cfc57a Mon

Re: [f2fs-dev] f2fs get_dnode_of_data oops

2014-09-10 Thread Jaegeuk Kim
On Tue, Sep 09, 2014 at 04:10:00PM +0800, Chao Yu wrote: Hi Jaegeuk, Looks good to me! One nitpick, how about judging this condition before we lock -i_mutex to avoid unneeded lock contention and invoking of i_size_read()? Agreed. From 0b4c5afde9b57c08b55d26725d228d5314cfc57a Mon Sep 17

RE: [f2fs-dev] f2fs get_dnode_of_data oops

2014-09-09 Thread Chao Yu
09, 2014 12:42 PM > To: Tommi Rantala > Cc: Dave Jones; trin...@vger.kernel.org; LKML; > linux-f2fs-de...@lists.sourceforge.net > Subject: Re: [f2fs-dev] f2fs get_dnode_of_data oops > > Hi Tommi, > > This patch should resolve this bug. > Thanks a lot. :) > > >F

RE: [f2fs-dev] f2fs get_dnode_of_data oops

2014-09-09 Thread Chao Yu
To: Tommi Rantala Cc: Dave Jones; trin...@vger.kernel.org; LKML; linux-f2fs-de...@lists.sourceforge.net Subject: Re: [f2fs-dev] f2fs get_dnode_of_data oops Hi Tommi, This patch should resolve this bug. Thanks a lot. :) From ee24677b9917583f50f16b6f59771439f91b890c Mon Sep 17 00:00:00