Re: [for-next][PATCH 15/16] ftrace: Add freeing algorithm to free ftrace_mod_maps

2017-10-08 Thread Joel Fernandes
Hi Steve, On Sun, Oct 8, 2017 at 11:42 AM, Steven Rostedt wrote: >> > "Joel Fernandes (Google)" wrote: >> > Also could you let me know what is the correct behavior of the filters >> > after a module being traced is unloaded, are the filters supposed to >> > be setup again after the module is unl

Re: [for-next][PATCH 15/16] ftrace: Add freeing algorithm to free ftrace_mod_maps

2017-10-08 Thread Joel Fernandes
Hi Steve, On Sat, Oct 7, 2017 at 9:52 PM, Joel Fernandes (Google) wrote: [..] >>> >>> On Fri, Oct 6, 2017 at 11:07 AM, Steven Rostedt wrote: >>> > From: "Steven Rostedt (VMware)" >>> > >>> > The ftrace_mod_map is a descriptor to save module init function names in >>> > case they were traced, an

Re: [for-next][PATCH 15/16] ftrace: Add freeing algorithm to free ftrace_mod_maps

2017-10-08 Thread Joel Fernandes
Hi Steve, On Sun, Oct 8, 2017 at 11:42 AM, Steven Rostedt wrote: > On Sun, 8 Oct 2017 01:42:15 -0700 [..] >> > "Joel Fernandes (Google)" wrote: >> [..] >> > Also could you let me know what is the correct behavior of the filters >> > after a module being traced is unloaded, are the filters suppos

Re: [for-next][PATCH 15/16] ftrace: Add freeing algorithm to free ftrace_mod_maps

2017-10-08 Thread Steven Rostedt
On Sun, 8 Oct 2017 01:42:15 -0700 Joel Fernandes wrote: > Hi Steve, > > > "Joel Fernandes (Google)" wrote: > [..] > > Also could you let me know what is the correct behavior of the filters > > after a module being traced is unloaded, are the filters supposed to > > be setup again after the mo

Re: [for-next][PATCH 15/16] ftrace: Add freeing algorithm to free ftrace_mod_maps

2017-10-08 Thread Joel Fernandes
Hi Steve, > "Joel Fernandes (Google)" wrote: [..] > Also could you let me know what is the correct behavior of the filters > after a module being traced is unloaded, are the filters supposed to > be setup again after the module is unloaded, before the module can be > loaded again? Actually I lea

Re: [for-next][PATCH 15/16] ftrace: Add freeing algorithm to free ftrace_mod_maps

2017-10-07 Thread Joel Fernandes (Google)
Hi Steve, On Sat, Oct 7, 2017 at 6:32 AM, Steven Rostedt wrote: > On Fri, 6 Oct 2017 23:41:25 -0700 > "Joel Fernandes (Google)" wrote: > >> Hi Steve, >> >> On Fri, Oct 6, 2017 at 11:07 AM, Steven Rostedt wrote: >> > From: "Steven Rostedt (VMware)" >> > >> > The ftrace_mod_map is a descriptor t

Re: [for-next][PATCH 15/16] ftrace: Add freeing algorithm to free ftrace_mod_maps

2017-10-07 Thread Steven Rostedt
On Fri, 6 Oct 2017 23:41:25 -0700 "Joel Fernandes (Google)" wrote: > Hi Steve, > > On Fri, Oct 6, 2017 at 11:07 AM, Steven Rostedt wrote: > > From: "Steven Rostedt (VMware)" > > > > The ftrace_mod_map is a descriptor to save module init function names in > > case they were traced, and the trac

Re: [for-next][PATCH 15/16] ftrace: Add freeing algorithm to free ftrace_mod_maps

2017-10-06 Thread Joel Fernandes (Google)
Hi Steve, On Fri, Oct 6, 2017 at 11:07 AM, Steven Rostedt wrote: > From: "Steven Rostedt (VMware)" > > The ftrace_mod_map is a descriptor to save module init function names in > case they were traced, and the trace output needs to reference the function > name from the function address. But afte

[for-next][PATCH 15/16] ftrace: Add freeing algorithm to free ftrace_mod_maps

2017-10-06 Thread Steven Rostedt
From: "Steven Rostedt (VMware)" The ftrace_mod_map is a descriptor to save module init function names in case they were traced, and the trace output needs to reference the function name from the function address. But after the function is unloaded, it the maps should be freed, as the rest of the