Re: [for-next][PATCH 6/6] tracing: Fix leak of ring buffer data when new instances creation fails

2014-06-10 Thread Steven Rostedt
On Tue, 10 Jun 2014 14:25:21 +0900 Namhyung Kim wrote: > > +static void free_trace_buffers(struct trace_array *tr) > > +{ > > + if (!tr) > > + return; > > + > > + if (tr->trace_buffer.buffer) { > > + ring_buffer_free(tr->trace_buffer.buffer); > > + tr->trace_bu

Re: [for-next][PATCH 6/6] tracing: Fix leak of ring buffer data when new instances creation fails

2014-06-09 Thread Namhyung Kim
On Fri, 06 Jun 2014 12:30:40 -0400, Steven Rostedt wrote: > From: "Steven Rostedt (Red Hat)" > > Yoshihiro Yunomae reported that the ring buffer data for a trace > instance does not get properly cleaned up when it fails. He proposed > a patch that manually cleaned the data up and addad a bunch of

[for-next][PATCH 6/6] tracing: Fix leak of ring buffer data when new instances creation fails

2014-06-06 Thread Steven Rostedt
From: "Steven Rostedt (Red Hat)" Yoshihiro Yunomae reported that the ring buffer data for a trace instance does not get properly cleaned up when it fails. He proposed a patch that manually cleaned the data up and addad a bunch of labels. The labels are not needed because all trace array is alloca