Re: [for-next][PATCH 7/8] tracing/probe: Reject exactly same probe event

2019-09-23 Thread Srikar Dronamraju
> > I think we need something like this: > > > > list_for_each_entry(pos, >probes, list) { > > orig = container_of(pos, struct trace_kprobe, tp); > > if (strcmp(trace_kprobe_symbol(orig), > >trace_kprobe_symbol(comp)) || > >

Re: [for-next][PATCH 7/8] tracing/probe: Reject exactly same probe event

2019-09-23 Thread Masami Hiramatsu
On Mon, 23 Sep 2019 16:12:53 +0530 Srikar Dronamraju wrote: > Hey Masami, Steven > > > > > +static bool trace_kprobe_has_same_kprobe(struct trace_kprobe *orig, > > +struct trace_kprobe *comp) > > +{ > > + struct trace_probe_event *tpe = orig->tp.event; >

Re: [for-next][PATCH 7/8] tracing/probe: Reject exactly same probe event

2019-09-23 Thread Srikar Dronamraju
Hey Masami, Steven > > +static bool trace_kprobe_has_same_kprobe(struct trace_kprobe *orig, > + struct trace_kprobe *comp) > +{ > + struct trace_probe_event *tpe = orig->tp.event; > + struct trace_probe *pos; > + int i; > + > +

[for-next][PATCH 7/8] tracing/probe: Reject exactly same probe event

2019-09-19 Thread Steven Rostedt
From: Masami Hiramatsu Reject exactly same probe events as existing probes. Multiprobe allows user to define multiple probes on same event. If user appends a probe which exactly same definition (same probe address and same arguments) on existing event, the event will record same probe