Re: [git patches] IDE updates (part 2)

2007-10-24 Thread Jeff Garzik
Al Viro wrote: Proposed addition to icside part, provided that ARM folks ACK it - gets icside to build and AFAICS it's correct: diff --git a/drivers/ata/pata_icside.c b/drivers/ata/pata_icside.c index be30923..842fe08 100644 --- a/drivers/ata/pata_icside.c +++ b/drivers/ata/pata_icside.c @@ -332

Re: [git patches] IDE updates (part 2)

2007-10-24 Thread Jeff Garzik
Russell King wrote: On Wed, Oct 24, 2007 at 08:53:09AM -0400, Jeff Garzik wrote: Russell King wrote: On Mon, Oct 15, 2007 at 04:07:47PM -0400, Jeff Garzik wrote: Russell King wrote: On Mon, Oct 15, 2007 at 03:54:16PM -0400, Jeff Garzik wrote: Al Viro wrote: Proposed addition to icside part,

Re: [git patches] IDE updates (part 2)

2007-10-24 Thread Russell King
in my mbox queue to be > merged upstream. Looks like it got my ack more than a week ago: | Date: Tue, 16 Oct 2007 16:55:07 +0100 | From: Russell King <[EMAIL PROTECTED]> | To: Al Viro <[EMAIL PROTECTED]> | Cc: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]>, | Linus Torval

Re: [git patches] IDE updates (part 2)

2007-10-24 Thread Jeff Garzik
Russell King wrote: On Mon, Oct 15, 2007 at 04:07:47PM -0400, Jeff Garzik wrote: Russell King wrote: On Mon, Oct 15, 2007 at 03:54:16PM -0400, Jeff Garzik wrote: Al Viro wrote: Proposed addition to icside part, provided that ARM folks ACK it - gets icside to build and AFAICS it's correct: AC

Re: [git patches] IDE updates (part 2)

2007-10-24 Thread Russell King
On Mon, Oct 15, 2007 at 04:07:47PM -0400, Jeff Garzik wrote: > Russell King wrote: > >On Mon, Oct 15, 2007 at 03:54:16PM -0400, Jeff Garzik wrote: > >>Al Viro wrote: > >>>Proposed addition to icside part, provided that ARM folks ACK it - gets > >>>icside to build and AFAICS it's correct: > >>ACK fr

Re: [git patches] IDE updates (part 2)

2007-10-16 Thread Bartlomiej Zolnierkiewicz
On Sunday 14 October 2007, Benjamin Herrenschmidt wrote: > > > How's about this patch? > > > > [PATCH] ide-pmac: fix pmac_ide_init_hwif_ports() > > > > * pmac_ide_init_hwif_ports() can be called by ide_init_hwif_ports() > > (through ppc_ide_md.ide_init_hwif hook) for non IDE PMAC interfaces. >

Re: [git patches] IDE updates (part 2)

2007-10-16 Thread Russell King
On Sun, Oct 14, 2007 at 01:12:39AM +0100, Al Viro wrote: > Proposed addition to icside part, provided that ARM folks ACK it - gets > icside to build and AFAICS it's correct: Booted and tested as working. Whatever-tag-that-is: Russell King <[EMAIL PROTECTED]> > diff --git a/drivers/ata/pata_icsid

Re: [git patches] IDE updates (part 2)

2007-10-15 Thread Jeff Garzik
Russell King wrote: On Mon, Oct 15, 2007 at 03:54:16PM -0400, Jeff Garzik wrote: Al Viro wrote: Proposed addition to icside part, provided that ARM folks ACK it - gets icside to build and AFAICS it's correct: ACK from me too... ARM folks? Will test tomorrow/Wednesday. Thanks. Sorry about

Re: [git patches] IDE updates (part 2)

2007-10-15 Thread Russell King
On Mon, Oct 15, 2007 at 03:54:16PM -0400, Jeff Garzik wrote: > Al Viro wrote: > >Proposed addition to icside part, provided that ARM folks ACK it - gets > >icside to build and AFAICS it's correct: > > ACK from me too... ARM folks? Will test tomorrow/Wednesday. -- Russell King Linux kernel

Re: [git patches] IDE updates (part 2)

2007-10-15 Thread Jeff Garzik
Al Viro wrote: Proposed addition to icside part, provided that ARM folks ACK it - gets icside to build and AFAICS it's correct: ACK from me too... ARM folks? - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordo

Re: [git patches] IDE updates (part 2)

2007-10-14 Thread Benjamin Herrenschmidt
> How's about this patch? > > [PATCH] ide-pmac: fix pmac_ide_init_hwif_ports() > > * pmac_ide_init_hwif_ports() can be called by ide_init_hwif_ports() > (through ppc_ide_md.ide_init_hwif hook) for non IDE PMAC interfaces. > If this is the case the hw->io_ports[] should be already setup by >

Re: [git patches] IDE updates (part 2)

2007-10-14 Thread Bartlomiej Zolnierkiewicz
On Sunday 14 October 2007, Benjamin Herrenschmidt wrote: > > On Sun, 2007-10-14 at 00:41 +0200, Bartlomiej Zolnierkiewicz wrote: > > On Sunday 14 October 2007, Alan Cox wrote: > > > > > > /* Probably a PCI interface... */ > > > > > > for (i = IDE_DATA_OFFSET; i <= IDE_STATU

Re: [git patches] IDE updates (part 2)

2007-10-14 Thread Bartlomiej Zolnierkiewicz
On Sunday 14 October 2007, Al Viro wrote: > Proposed addition to icside part, provided that ARM folks ACK it - gets > icside to build and AFAICS it's correct: the patch looks good and gets my ACK but it is for Jeff ;) > diff --git a/drivers/ata/pata_icside.c b/drivers/ata/pata_icside.c > index be

Re: [git patches] IDE updates (part 2)

2007-10-13 Thread Al Viro
Proposed addition to icside part, provided that ARM folks ACK it - gets icside to build and AFAICS it's correct: diff --git a/drivers/ata/pata_icside.c b/drivers/ata/pata_icside.c index be30923..842fe08 100644 --- a/drivers/ata/pata_icside.c +++ b/drivers/ata/pata_icside.c @@ -332,12 +332,13 @@ st

Re: [git patches] IDE updates (part 2)

2007-10-13 Thread Benjamin Herrenschmidt
On Sun, 2007-10-14 at 00:41 +0200, Bartlomiej Zolnierkiewicz wrote: > On Sunday 14 October 2007, Alan Cox wrote: > > > > > /* Probably a PCI interface... */ > > > > > for (i = IDE_DATA_OFFSET; i <= IDE_STATUS_OFFSET; ++i) > > > > > hw->io_ports[i]

Re: [git patches] IDE updates (part 2)

2007-10-13 Thread Bartlomiej Zolnierkiewicz
On Sunday 14 October 2007, Alan Cox wrote: > > > > /* Probably a PCI interface... */ > > > > for (i = IDE_DATA_OFFSET; i <= IDE_STATUS_OFFSET; ++i) > > > > hw->io_ports[i] = data_port + i - > > > > IDE_DATA_OFFSET; > > > > hw-

Re: [git patches] IDE updates (part 2)

2007-10-13 Thread Alan Cox
> > > /* Probably a PCI interface... */ > > > for (i = IDE_DATA_OFFSET; i <= IDE_STATUS_OFFSET; ++i) > > > hw->io_ports[i] = data_port + i - IDE_DATA_OFFSET; > > > hw->io_ports[IDE_CONTROL_OFFSET] = ctrl_port; Ok so in actual fact - The piece of cod

Re: [git patches] IDE updates (part 2)

2007-10-13 Thread Bartlomiej Zolnierkiewicz
On Saturday 13 October 2007, Alan Cox wrote: > > Comment in pmac_ide_init_hwif_ports() is highly misleading as this function > > returns early only for "normal" IDE PCI devices (pmac_ide_init_hwif_ports() > > can be called outside ide-pmac driver through ppc_ide_md). > > Follow the code you pasted

Re: [git patches] IDE updates (part 2)

2007-10-13 Thread Alan Cox
> Comment in pmac_ide_init_hwif_ports() is highly misleading as this function > returns early only for "normal" IDE PCI devices (pmac_ide_init_hwif_ports() > can be called outside ide-pmac driver through ppc_ide_md). Follow the code you pasted > pmif->regbase = (unsigned long) base + 0x2000

Re: [git patches] IDE updates (part 2)

2007-10-13 Thread Bartlomiej Zolnierkiewicz
On Saturday 13 October 2007, Alan Cox wrote: > On Sat, 13 Oct 2007 18:25:24 +0200 > Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]> wrote: > > > > > Hi, > > > > highlights of this update: > > > > * Rework of IDE PMAC host driver: bugfixes, removal of the code > > duplicated from the IDE core an

Re: [git patches] IDE updates (part 2)

2007-10-13 Thread Alan Cox
On Sat, 13 Oct 2007 18:25:24 +0200 Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]> wrote: > > Hi, > > highlights of this update: > > * Rework of IDE PMAC host driver: bugfixes, removal of the code > duplicated from the IDE core and conversion to use the generic > DMA tuning code path (the rew