Re: [git pull] Fix recent Ocfs2 breakage

2008-01-29 Thread Joel Becker
On Tue, Jan 29, 2008 at 02:18:58PM -0800, Joel Becker wrote: > But I'm still not understanding what you mean by "1 kobject for > the directory". We have one kobject for the "logmask" directory, and > then attributes for each log type. I don't see how that would change. Oh, wait, I'

Re: [git pull] Fix recent Ocfs2 breakage

2008-01-29 Thread Joel Becker
On Tue, Jan 29, 2008 at 10:54:48AM -0800, Greg KH wrote: > > ocfs2 kobject usage, or other folks'? If there's anything in > > the ocfs2 usage that you are unsure of, feel free to ask! > > Ok, great. Here's a few questions: > > - ocfs2/cluster/sys.c creates a single kset, o2cb, that is in

Re: [git pull] Fix recent Ocfs2 breakage

2008-01-29 Thread Greg KH
On Mon, Jan 28, 2008 at 11:44:02PM -0800, Joel Becker wrote: > On Mon, Jan 28, 2008 at 09:08:04PM -0800, Greg KH wrote: > > And please please please please document stuff like this, and all of the > > different files you have in this subdirectory in Documentation/ABI/ so > > Huh, I didn't kn

Re: [git pull] Fix recent Ocfs2 breakage

2008-01-29 Thread Greg KH
On Mon, Jan 28, 2008 at 09:58:25PM -0800, Mark Fasheh wrote: > On Mon, Jan 28, 2008 at 09:08:04PM -0800, Greg KH wrote: > > And please please please please document stuff like this, and all of the > > different files you have in this subdirectory in Documentation/ABI/ so > > those of us who are try

Re: [git pull] Fix recent Ocfs2 breakage

2008-01-28 Thread Joel Becker
On Mon, Jan 28, 2008 at 09:08:04PM -0800, Greg KH wrote: > And please please please please document stuff like this, and all of the > different files you have in this subdirectory in Documentation/ABI/ so Huh, I didn't know Documentation/ABI existed. That would certainly help in the futur

Re: [git pull] Fix recent Ocfs2 breakage

2008-01-28 Thread Mark Fasheh
On Mon, Jan 28, 2008 at 09:08:04PM -0800, Greg KH wrote: > > Joel Becker (1): > > ocfs2: Fix userspace ABI breakage in sysfs > > This is fine with me, for now. Great, thanks. > > From: Joel Becker <[EMAIL PROTECTED]> > > > > ocfs2: Fix userspace ABI breakage in sysfs > > > > The userspa

Re: [git pull] Fix recent Ocfs2 breakage

2008-01-28 Thread Greg KH
On Mon, Jan 28, 2008 at 07:33:07PM -0800, Mark Fasheh wrote: > Greg's commit c60b71787982cefcf9fa09aa281fa8c4c685d557 inadvertantly broke > Ocfs2 userspace ABI, so I have a rather high priority single line patch from > Joel to fix things up for you to pull. A copy of the patch is attached to > the

[git pull] Fix recent Ocfs2 breakage

2008-01-28 Thread Mark Fasheh
Greg's commit c60b71787982cefcf9fa09aa281fa8c4c685d557 inadvertantly broke Ocfs2 userspace ABI, so I have a rather high priority single line patch from Joel to fix things up for you to pull. A copy of the patch is attached to the bottom of this e-mail. Embarassingly enough, I missed this while acki