Re: [GIT PULL] vfs: fix copy_file_range bad behavior

2019-07-10 Thread pr-tracker-bot
The pull request you sent on Tue, 9 Jul 2019 09:39:48 -0700: > git://git.kernel.org/pub/scm/fs/xfs/xfs-linux.git tags/copy-file-range-fixes-1 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/40f06c799539739a08a56be8a096f56aeed05731 Thank you! -- Deet-doot-dot, I am a

[GIT PULL] vfs: fix copy_file_range bad behavior

2019-07-09 Thread Darrick J. Wong
Hi Linus, Please pull this series to fix numerous parameter checking problems and inconsistent behaviors in the new(ish) copy_file_range system call. Now the system call will actually check its range parameters correctly; refuse to copy into files for which the caller does not have sufficient pri

Re: [GIT PULL] vfs: fix many problems in vfs clone/dedupe implementation

2018-11-04 Thread Dave Chinner
On Sat, Nov 03, 2018 at 10:13:37AM -0700, Linus Torvalds wrote: > On Fri, Nov 2, 2018 at 4:36 PM Dave Chinner wrote: > > > > On Fri, Nov 02, 2018 at 09:35:23AM -0700, Linus Torvalds wrote: > > > > > > I don't love the timing of this at the end of the merge window, but > > > pulled, > > > > When w

Re: [GIT PULL] vfs: fix many problems in vfs clone/dedupe implementation

2018-11-03 Thread Linus Torvalds
On Fri, Nov 2, 2018 at 4:36 PM Dave Chinner wrote: > > On Fri, Nov 02, 2018 at 09:35:23AM -0700, Linus Torvalds wrote: > > > > I don't love the timing of this at the end of the merge window, but pulled, > > When would have been a better time? It's too big for a late -rc, and > it contains stuff th

Re: [GIT PULL] vfs: fix many problems in vfs clone/dedupe implementation

2018-11-02 Thread Dave Chinner
On Fri, Nov 02, 2018 at 09:35:23AM -0700, Linus Torvalds wrote: > On Thu, Nov 1, 2018 at 10:15 PM Dave Chinner wrote: > > > > Can you please pull update containing a rework of the VFS clone and > > dedupe file range infrastructure from the tag listed below? > > I don't love the timing of this at

Re: [GIT PULL] vfs: fix many problems in vfs clone/dedupe implementation

2018-11-02 Thread Linus Torvalds
On Thu, Nov 1, 2018 at 10:15 PM Dave Chinner wrote: > > Can you please pull update containing a rework of the VFS clone and > dedupe file range infrastructure from the tag listed below? I don't love the timing of this at the end of the merge window, but pulled, Linus

[GIT PULL] vfs: fix many problems in vfs clone/dedupe implementation

2018-11-01 Thread Dave Chinner
Hi Linus, Can you please pull update containing a rework of the VFS clone and dedupe file range infrastructure from the tag listed below? We discovered many issues with these interfaces late in the 4.19 cycle - the worst of them (data corruption, setuid stripping) were fixed for XFS in 4.19-rc8,

Re: [git pull] vfs fix

2016-11-28 Thread Yan, Zheng
> On 27 Nov 2016, at 10:51, Al Viro wrote: > > On Sun, Nov 27, 2016 at 02:25:09AM +, Al Viro wrote: > >> Anyway, leaving that BUG_ON() had been wrong; I can send a followup >> massaging that thing as you've suggested, if you are interested in >> that. But keep in mind that the whole iov_it

Re: [git pull] vfs fix

2016-11-26 Thread Al Viro
On Sun, Nov 27, 2016 at 02:51:18AM +, Al Viro wrote: ... and screwed up Cc due to comma in S-O-B of commit in question. My apologies.

Re: [git pull] vfs fix

2016-11-26 Thread Linus Torvalds
On Sat, Nov 26, 2016 at 6:25 PM, Al Viro wrote: > > Two issues here. One is that iov_iter_get_pages{,_alloc}() calling > conventions are fucking ugly. No arguments there. I was going to suggest adding an "int *npages" argument and letting that function fill that in together with the page array,

Re: [git pull] vfs fix

2016-11-26 Thread Al Viro
On Sun, Nov 27, 2016 at 02:25:09AM +, Al Viro wrote: > Anyway, leaving that BUG_ON() had been wrong; I can send a followup > massaging that thing as you've suggested, if you are interested in > that. But keep in mind that the whole iov_iter_get_pages...() calling > conventions are going to be

Re: [git pull] vfs fix

2016-11-26 Thread Al Viro
On Sat, Nov 26, 2016 at 05:48:54PM -0800, Linus Torvalds wrote: > That's what all the other users do, and that's what should be the > "right usage pattern", afaik. The number of pages really *is* > calculated as > >int n = DIV_ROUND_UP(result + offs, PAGE_SIZE); > > in other iov_iter_get_

Re: [git pull] vfs fix

2016-11-26 Thread Linus Torvalds
On Sat, Nov 26, 2016 at 5:13 PM, Al Viro wrote: > > Al Viro (1): > fix default_file_splice_read() Ugh. I absolutely _hate_ this: BUG_ON(dummy); because it makes no sense. I'm assuming that "dummy" here is "start_offset", and that you want to make sure that there are no initial of

[git pull] vfs fix

2016-11-26 Thread Al Viro
The following changes since commit 3ad0e83cf86bcaeb6ca3c37060a3ce866b25fb42: Merge branch 'parisc-4.9-4' of git://git.kernel.org/pub/scm/linux/kernel/git/deller/parisc-linux (2016-11-25 16:47:15 -0800) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/vi

[git pull] vfs fix

2016-03-30 Thread Al Viro
The following changes since commit f55532a0c0b8bb6148f4e07853b876ef73bc69ca: Linux 4.6-rc1 (2016-03-26 16:03:24 -0700) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs.git for-linus for you to fetch changes up to 7500c38ac3258815f86f41744a538850

[git pull] vfs fix

2015-05-31 Thread Al Viro
Off-by-one in d_walk()/__dentry_kill() race fix. It's very hard to hit; possible in the same conditions as the original bug, except that you need the skipped branch to contain all the remaining evictables, so that the d_walk()-calling loop in d_invalidate() decides there's nothing more to do and d