Re: [git pull] vfs.git bits and pieces

2013-11-21 Thread Kirill A. Shutemov
Andrew Morton wrote: > On Wed, 20 Nov 2013 14:33:35 -0800 Linus Torvalds > wrote: > > > On Wed, Nov 20, 2013 at 9:47 AM, Al Viro wrote: > > > > > > BTW, something odd happened to mm/memory.c - either a mangled patch > > > or a lost followup: > > > > > > commit ea1e7ed33708 > > > mm: cre

Re: [git pull] vfs.git bits and pieces

2013-11-20 Thread Damien Wyart
> > BTW, something odd happened to mm/memory.c - either a mangled patch > > or a lost followup: > > commit ea1e7ed33708 > > mm: create a separate slab for page->ptl allocation > > Fair enough, and yes, it does create that separate slab. The problem > > is, it's still using kmalloc/kfree f

Re: [git pull] vfs.git bits and pieces

2013-11-20 Thread Andrew Morton
On Wed, 20 Nov 2013 14:33:35 -0800 Linus Torvalds wrote: > On Wed, Nov 20, 2013 at 9:47 AM, Al Viro wrote: > > > > BTW, something odd happened to mm/memory.c - either a mangled patch > > or a lost followup: > > > > commit ea1e7ed33708 > > mm: create a separate slab for page->ptl allocat

Re: [git pull] vfs.git bits and pieces

2013-11-20 Thread Linus Torvalds
On Wed, Nov 20, 2013 at 9:47 AM, Al Viro wrote: > > BTW, something odd happened to mm/memory.c - either a mangled patch > or a lost followup: > > commit ea1e7ed33708 > mm: create a separate slab for page->ptl allocation > > Fair enough, and yes, it does create that separate slab. The prob

Re: [git pull] vfs.git bits and pieces

2013-11-20 Thread Joe Perches
On Wed, 2013-11-20 at 22:16 +, Al Viro wrote: > While digging in the same area: > > Wrong page freed on preallocate_pmds() failure exit > > Note that pmds[i] is simply uninitialized at that point... > Granted, it's very hard to hit (you need split page locks > *and* kmalloc(sizeof(spinlock_t)

Re: [git pull] vfs.git bits and pieces

2013-11-20 Thread Al Viro
On Wed, Nov 20, 2013 at 05:47:12PM +, Al Viro wrote: > On Wed, Nov 20, 2013 at 05:42:11PM +, Al Viro wrote: > > [Apologies for delay; I'd spent the last day hunting down something that > > turned out to be a VM leak completely unrelated to this stuff - it's > > present in mainline, for star

Re: [git pull] vfs.git bits and pieces

2013-11-20 Thread Al Viro
On Wed, Nov 20, 2013 at 05:42:11PM +, Al Viro wrote: > [Apologies for delay; I'd spent the last day hunting down something that > turned out to be a VM leak completely unrelated to this stuff - it's > present in mainline, for starters. Unreliable reproducers make for fun > bisects ;-/ Anyway,

[git pull] vfs.git bits and pieces

2013-11-20 Thread Al Viro
[Apologies for delay; I'd spent the last day hunting down something that turned out to be a VM leak completely unrelated to this stuff - it's present in mainline, for starters. Unreliable reproducers make for fun bisects ;-/ Anyway, by now I'm absolutely sure that this is a VM bug and not somethi