Re: [greybus-dev] [PATCH] staging: greybus: mark PM functions as __maybe_unused

2017-05-19 Thread Arnd Bergmann
On Fri, May 19, 2017 at 5:40 AM, Viresh Kumar wrote: > On 18-05-17, 16:51, Arnd Bergmann wrote: >> I find that a lot of users get the #ifdef wrong, either using the wrong >> macro (CONFIG_PM vs CONFIG_PM_SLEEP) or not using the right >> set of functions (e.g. calling a

Re: [greybus-dev] [PATCH] staging: greybus: mark PM functions as __maybe_unused

2017-05-19 Thread Arnd Bergmann
On Fri, May 19, 2017 at 5:40 AM, Viresh Kumar wrote: > On 18-05-17, 16:51, Arnd Bergmann wrote: >> I find that a lot of users get the #ifdef wrong, either using the wrong >> macro (CONFIG_PM vs CONFIG_PM_SLEEP) or not using the right >> set of functions (e.g. calling a function only from the

Re: [greybus-dev] [PATCH] staging: greybus: mark PM functions as __maybe_unused

2017-05-18 Thread Viresh Kumar
On 18-05-17, 16:51, Arnd Bergmann wrote: > I find that a lot of users get the #ifdef wrong, either using the wrong > macro (CONFIG_PM vs CONFIG_PM_SLEEP) or not using the right > set of functions (e.g. calling a function only from the suspend handler). > > The __maybe_unused annotation avoids

Re: [greybus-dev] [PATCH] staging: greybus: mark PM functions as __maybe_unused

2017-05-18 Thread Viresh Kumar
On 18-05-17, 16:51, Arnd Bergmann wrote: > I find that a lot of users get the #ifdef wrong, either using the wrong > macro (CONFIG_PM vs CONFIG_PM_SLEEP) or not using the right > set of functions (e.g. calling a function only from the suspend handler). > > The __maybe_unused annotation avoids

Re: [greybus-dev] [PATCH] staging: greybus: mark PM functions as __maybe_unused

2017-05-18 Thread Arnd Bergmann
On Thu, May 18, 2017 at 4:18 PM, Viresh Kumar wrote: > On 18-05-17, 15:28, Arnd Bergmann wrote: >> Enabling the arche platform for compile testing showed a harmless >> warning with CONFIG_PM=n: >> >> drivers/staging/greybus/arche-platform.c:632:12: error: >>

Re: [greybus-dev] [PATCH] staging: greybus: mark PM functions as __maybe_unused

2017-05-18 Thread Arnd Bergmann
On Thu, May 18, 2017 at 4:18 PM, Viresh Kumar wrote: > On 18-05-17, 15:28, Arnd Bergmann wrote: >> Enabling the arche platform for compile testing showed a harmless >> warning with CONFIG_PM=n: >> >> drivers/staging/greybus/arche-platform.c:632:12: error: >> 'arche_platform_resume' defined but

Re: [greybus-dev] [PATCH] staging: greybus: mark PM functions as __maybe_unused

2017-05-18 Thread Viresh Kumar
On 18-05-17, 15:28, Arnd Bergmann wrote: > Enabling the arche platform for compile testing showed a harmless > warning with CONFIG_PM=n: > > drivers/staging/greybus/arche-platform.c:632:12: error: > 'arche_platform_resume' defined but not used [-Werror=unused-function] >

Re: [greybus-dev] [PATCH] staging: greybus: mark PM functions as __maybe_unused

2017-05-18 Thread Viresh Kumar
On 18-05-17, 15:28, Arnd Bergmann wrote: > Enabling the arche platform for compile testing showed a harmless > warning with CONFIG_PM=n: > > drivers/staging/greybus/arche-platform.c:632:12: error: > 'arche_platform_resume' defined but not used [-Werror=unused-function] >