Re: [linux-pm] Re: [linux-lvm] 2.6.22-rc4 XFS fails after hibernate/resume

2007-06-29 Thread David Greaves
Rafael J. Wysocki wrote: On Friday, 29 June 2007 09:54, David Greaves wrote: David Chinner wrote: On Fri, Jun 29, 2007 at 08:40:00AM +0100, David Greaves wrote: What happens if a filesystem is frozen and I hibernate? Will it be thawed when I resume? If you froze it yourself, then you'll have

Re: [linux-pm] Re: [linux-lvm] 2.6.22-rc4 XFS fails after hibernate/resume

2007-06-29 Thread Rafael J. Wysocki
On Friday, 29 June 2007 09:54, David Greaves wrote: > David Chinner wrote: > > On Fri, Jun 29, 2007 at 08:40:00AM +0100, David Greaves wrote: > >> What happens if a filesystem is frozen and I hibernate? > >> Will it be thawed when I resume? > > > > If you froze it yourself, then you'll have to tha

Re: [linux-pm] Re: [linux-lvm] 2.6.22-rc4 XFS fails after hibernate/resume

2007-06-29 Thread David Greaves
David Chinner wrote: On Fri, Jun 29, 2007 at 08:40:00AM +0100, David Greaves wrote: What happens if a filesystem is frozen and I hibernate? Will it be thawed when I resume? If you froze it yourself, then you'll have to thaw it yourself. So hibernate will not attempt to re-freeze a frozen fs

Re: [linux-pm] Re: [linux-lvm] 2.6.22-rc4 XFS fails after hibernate/resume

2007-06-29 Thread David Chinner
On Fri, Jun 29, 2007 at 08:40:00AM +0100, David Greaves wrote: > What happens if a filesystem is frozen and I hibernate? > Will it be thawed when I resume? If you froze it yourself, then you'll have to thaw it yourself. Cheers, Dave. -- Dave Chinner Principal Engineer SGI Australian Software Gr

Re: [linux-pm] Re: [linux-lvm] 2.6.22-rc4 XFS fails after hibernate/resume

2007-06-29 Thread David Greaves
David Chinner wrote: On Fri, Jun 29, 2007 at 12:16:44AM +0200, Rafael J. Wysocki wrote: There are two solutions possible, IMO. One would be to make these workqueues freezable, which is possible, but hacky and Oleg didn't like that very much. The second would be to freeze XFS from within the hib

Re: [linux-pm] Re: [linux-lvm] 2.6.22-rc4 XFS fails after hibernate/resume

2007-06-28 Thread David Chinner
On Fri, Jun 29, 2007 at 12:16:44AM +0200, Rafael J. Wysocki wrote: > There are two solutions possible, IMO. One would be to make these workqueues > freezable, which is possible, but hacky and Oleg didn't like that very much. > The second would be to freeze XFS from within the hibernation code path

Re: [linux-lvm] 2.6.22-rc4 XFS fails after hibernate/resume

2007-06-28 Thread David Chinner
On Wed, Jun 27, 2007 at 08:49:24PM +, Pavel Machek wrote: > Hi! > > > FWIW, I'm on record stating that "sync" is not sufficient to quiesce an XFS > > filesystem for a suspend/resume to work safely and have argued that the only > > Hmm, so XFS writes to disk even when its threads are frozen?

Re: [linux-pm] Re: [linux-lvm] 2.6.22-rc4 XFS fails after hibernate/resume

2007-06-28 Thread Rafael J. Wysocki
On Friday, 29 June 2007 00:00, Pavel Machek wrote: > On Thu 2007-06-28 17:27:34, Rafael J. Wysocki wrote: > > On Wednesday, 27 June 2007 22:49, Pavel Machek wrote: > > > Hi! > > > > > > > FWIW, I'm on record stating that "sync" is not sufficient to quiesce an > > > > XFS > > > > filesystem for a

Re: [linux-pm] Re: [linux-lvm] 2.6.22-rc4 XFS fails after hibernate/resume

2007-06-28 Thread Pavel Machek
On Thu 2007-06-28 17:27:34, Rafael J. Wysocki wrote: > On Wednesday, 27 June 2007 22:49, Pavel Machek wrote: > > Hi! > > > > > FWIW, I'm on record stating that "sync" is not sufficient to quiesce an > > > XFS > > > filesystem for a suspend/resume to work safely and have argued that the > > > onl

Re: [linux-lvm] 2.6.22-rc4 XFS fails after hibernate/resume

2007-06-28 Thread Rafael J. Wysocki
On Wednesday, 27 June 2007 22:49, Pavel Machek wrote: > Hi! > > > FWIW, I'm on record stating that "sync" is not sufficient to quiesce an XFS > > filesystem for a suspend/resume to work safely and have argued that the only > > Hmm, so XFS writes to disk even when its threads are frozen? > > > sa

Re: [linux-lvm] 2.6.22-rc4 XFS fails after hibernate/resume

2007-06-28 Thread Pavel Machek
Hi! > FWIW, I'm on record stating that "sync" is not sufficient to quiesce an XFS > filesystem for a suspend/resume to work safely and have argued that the only Hmm, so XFS writes to disk even when its threads are frozen? > safe thing to do is freeze the filesystem before suspend and thaw it aft

Re: [linux-lvm] 2.6.22-rc4 XFS fails after hibernate/resume

2007-06-18 Thread David Greaves
OK, just an quick ack When I resumed tonight (having done a freeze/thaw over the suspend) some libata errors threw up during the resume and there was an eventual hard hang. Maybe I spoke to soon? I'm going to have to do some more testing... David Chinner wrote: On Mon, Jun 18, 2007 at 08:49

Re: [linux-lvm] 2.6.22-rc4 XFS fails after hibernate/resume

2007-06-18 Thread David Chinner
On Mon, Jun 18, 2007 at 08:49:34AM +0100, David Greaves wrote: > David Greaves wrote: > >OK, that gave me an idea. > > > >Freeze the filesystem > >md5sum the lvm > >hibernate > >resume > >md5sum the lvm > > >So the lvm and below looks OK... > > > >I'll see how it behaves now the filesystem has bee

Re: [linux-lvm] 2.6.22-rc4 XFS fails after hibernate/resume

2007-06-18 Thread David Greaves
David Greaves wrote: David Robinson wrote: David Greaves wrote: This isn't a regression. I was seeing these problems on 2.6.21 (but 22 was in -rc so I waited to try it). I tried 2.6.22-rc4 (with Tejun's patches) to see if it had improved - no. Note this is a different (desktop) machine to

Re: [linux-lvm] 2.6.22-rc4 XFS fails after hibernate/resume

2007-06-17 Thread David Greaves
David Robinson wrote: David Greaves wrote: This isn't a regression. I was seeing these problems on 2.6.21 (but 22 was in -rc so I waited to try it). I tried 2.6.22-rc4 (with Tejun's patches) to see if it had improved - no. Note this is a different (desktop) machine to that involved my recent

Re: [linux-lvm] 2.6.22-rc4 XFS fails after hibernate/resume

2007-06-16 Thread David Robinson
David Greaves wrote: This isn't a regression. I was seeing these problems on 2.6.21 (but 22 was in -rc so I waited to try it). I tried 2.6.22-rc4 (with Tejun's patches) to see if it had improved - no. Note this is a different (desktop) machine to that involved my recent bugs. The machine wil