Re: [linux-pm] Re: swsusp 'disk' fails in bk-current - intel_agp at fault?

2005-04-01 Thread Stefan Seyfried
Rafael J. Wysocki wrote: > Hi, >> On Fri, 2005-04-01 at 08:18, Pavel Machek wrote: >> > I believe we should freeze hotplug before processes. > > I agree. IMO user space should not be considered as available once we have > started freezing processes, so hotplug should be disabled before. By the s

Re: [linux-pm] Re: swsusp 'disk' fails in bk-current - intel_agp at fault?

2005-04-01 Thread Rafael J. Wysocki
Hi, On Friday, 1 of April 2005 00:28, Nigel Cunningham wrote: > Hi. > > On Fri, 2005-04-01 at 08:18, Pavel Machek wrote: > > Hi! > > > > > > > Ok, what do you think about this one? > > > > > > > > > > === > > > > > > > > > > swsusp:

Re: [linux-pm] Re: swsusp 'disk' fails in bk-current - intel_agp at fault?

2005-03-31 Thread Nigel Cunningham
Hi. On Fri, 2005-04-01 at 08:18, Pavel Machek wrote: > Hi! > > > > > Ok, what do you think about this one? > > > > > > > > === > > > > > > > > swsusp: disable usermodehelper after generating memory snapshot and > > > > before

Re: [linux-pm] Re: swsusp 'disk' fails in bk-current - intel_agp at fault?

2005-03-31 Thread Pavel Machek
Hi! > > > Ok, what do you think about this one? > > > > > > === > > > > > > swsusp: disable usermodehelper after generating memory snapshot and > > > before resuming devices, so when device fails to resume we > > > won

Re: [linux-pm] Re: swsusp 'disk' fails in bk-current - intel_agp at fault?

2005-03-31 Thread Nigel Cunningham
Hi. On Fri, 2005-04-01 at 02:32, Dmitry Torokhov wrote: > On Thu, 31 Mar 2005 08:02:44 -0800 (PST), Patrick Mochel > <[EMAIL PROTECTED]> wrote: > > > > On Thu, 31 Mar 2005, Dmitry Torokhov wrote: > > > > > Ok, what do you think about this one? > > > > > >

Re: [linux-pm] Re: swsusp 'disk' fails in bk-current - intel_agp at fault?

2005-03-31 Thread Dmitry Torokhov
On Thu, 31 Mar 2005 08:02:44 -0800 (PST), Patrick Mochel <[EMAIL PROTECTED]> wrote: > > On Thu, 31 Mar 2005, Dmitry Torokhov wrote: > > > Ok, what do you think about this one? > > > > === > > > > swsusp: disable usermodehelper after

Re: [linux-pm] Re: swsusp 'disk' fails in bk-current - intel_agp at fault?

2005-03-31 Thread Patrick Mochel
On Thu, 31 Mar 2005, Dmitry Torokhov wrote: > Ok, what do you think about this one? > > === > > swsusp: disable usermodehelper after generating memory snapshot and > before resuming devices, so when device fails to resume we

Re: [linux-pm] Re: swsusp 'disk' fails in bk-current - intel_agp at fault?

2005-03-31 Thread Dmitry Torokhov
On Thu, 31 Mar 2005 10:39:10 +0200, Pavel Machek <[EMAIL PROTECTED]> wrote: > > int swsusp_write(void) > > { > > int error; > > - device_resume(); > > lock_swapdevices(); > > error = write_suspend_image(); > > /* This will unlock ignored swap devices since writing is >

Re: [linux-pm] Re: swsusp 'disk' fails in bk-current - intel_agp at fault?

2005-03-31 Thread Pavel Machek
Hi! > > > > We currently freeze processes for suspend-to-ram, too. I guess that > > > > disable_usermodehelper is probably better and that in_suspend() should > > > > only be used for sanity checks... go with disable_usermodehelper and > > > > sorry for the noise. > > > > > > Here's another possi

Re: [linux-pm] Re: swsusp 'disk' fails in bk-current - intel_agp at fault?

2005-03-30 Thread Dmitry Torokhov
On Tuesday 29 March 2005 17:35, Pavel Machek wrote: > Hi! > > > > We currently freeze processes for suspend-to-ram, too. I guess that > > > disable_usermodehelper is probably better and that in_suspend() should > > > only be used for sanity checks... go with disable_usermodehelper and > > > sorry

Re: [linux-pm] Re: swsusp 'disk' fails in bk-current - intel_agp at fault?

2005-03-30 Thread Greg KH
On Tue, Mar 29, 2005 at 01:23:35PM -0800, Patrick Mochel wrote: > > On Tue, 29 Mar 2005, Pavel Machek wrote: > > > I don't really want us to try execve during resume... Could we simply > > artifically fail that execve with something if (in_suspend()) return > > -EINVAL; [except that in_suspend()

Re: [linux-pm] Re: swsusp 'disk' fails in bk-current - intel_agp at fault?

2005-03-29 Thread Nigel Cunningham
Hi. On Wed, 2005-03-30 at 08:35, Pavel Machek wrote: > Hi! > > > > We currently freeze processes for suspend-to-ram, too. I guess that > > > disable_usermodehelper is probably better and that in_suspend() should > > > only be used for sanity checks... go with disable_usermodehelper and > > > sorr

Re: [linux-pm] Re: swsusp 'disk' fails in bk-current - intel_agp at fault?

2005-03-29 Thread Pavel Machek
Hi! > > We currently freeze processes for suspend-to-ram, too. I guess that > > disable_usermodehelper is probably better and that in_suspend() should > > only be used for sanity checks... go with disable_usermodehelper and > > sorry for the noise. > > Here's another possibility: Freeze the workq

Re: [linux-pm] Re: swsusp 'disk' fails in bk-current - intel_agp at fault?

2005-03-29 Thread Nigel Cunningham
Hi. On Wed, 2005-03-30 at 07:44, Pavel Machek wrote: > We currently freeze processes for suspend-to-ram, too. I guess that > disable_usermodehelper is probably better and that in_suspend() should > only be used for sanity checks... go with disable_usermodehelper and > sorry for the noise. Here's

Re: [linux-pm] Re: swsusp 'disk' fails in bk-current - intel_agp at fault?

2005-03-29 Thread Dmitry Torokhov
On Tue, 29 Mar 2005 13:23:35 -0800 (PST), Patrick Mochel <[EMAIL PROTECTED]> wrote: > > On Tue, 29 Mar 2005, Pavel Machek wrote: > > > I don't really want us to try execve during resume... Could we simply > > artifically fail that execve with something if (in_suspend()) return > > -EINVAL; [excep

Re: [linux-pm] Re: swsusp 'disk' fails in bk-current - intel_agp at fault?

2005-03-29 Thread Patrick Mochel
On Tue, 29 Mar 2005, Pavel Machek wrote: > I don't really want us to try execve during resume... Could we simply > artifically fail that execve with something if (in_suspend()) return > -EINVAL; [except that in_suspend() just is not there, but there were > some proposals to add it]. > > Or just a