Re: [linux-safety] [PATCH] taskstats: remove unneeded dead assignment

2020-11-10 Thread Dan Carpenter
On Fri, Nov 06, 2020 at 12:04:53PM +, Sudip Mukherjee wrote: > Hi Lukas, > > On 06/11/2020 10:31, Lukas Bulwahn wrote: > > > > > > On Fri, 6 Nov 2020, Sudip Mukherjee wrote: > > > >> Hi Lukas, > >> > > > > > > > I did not try but I bet (a beverage of your choice) that the object code >

Re: [linux-safety] [PATCH] taskstats: remove unneeded dead assignment

2020-11-06 Thread Lukas Bulwahn
On Fri, 6 Nov 2020, Sudip Mukherjee wrote: > Hi Lukas, > > On 06/11/2020 10:31, Lukas Bulwahn wrote: > > > > > > On Fri, 6 Nov 2020, Sudip Mukherjee wrote: > > > >> Hi Lukas, > >> > > > > > > > I did not try but I bet (a beverage of your choice) that the object code > > remains the

Re: [linux-safety] [PATCH] taskstats: remove unneeded dead assignment

2020-11-06 Thread Sudip Mukherjee
Hi Lukas, On 06/11/2020 10:31, Lukas Bulwahn wrote: > > > On Fri, 6 Nov 2020, Sudip Mukherjee wrote: > >> Hi Lukas, >> > > I did not try but I bet (a beverage of your choice) that the object code > remains the same also for your suggested patch. Try to disprove my claim > and possibly

Re: [linux-safety] [PATCH] taskstats: remove unneeded dead assignment

2020-11-06 Thread Sudip Mukherjee
Hi Lukas, On 06/11/2020 06:22, Lukas Bulwahn wrote: > make clang-analyzer on x86_64 defconfig caught my attention with: > > kernel/taskstats.c:120:2: warning: Value stored to 'rc' is never read \ > [clang-analyzer-deadcode.DeadStores] > rc = 0; > ^ > > Commit

Re: [linux-safety] [PATCH] taskstats: remove unneeded dead assignment

2020-11-06 Thread Lukas Bulwahn
On Fri, 6 Nov 2020, Sudip Mukherjee wrote: > Hi Lukas, > > On 06/11/2020 06:22, Lukas Bulwahn wrote: > > make clang-analyzer on x86_64 defconfig caught my attention with: > > > > kernel/taskstats.c:120:2: warning: Value stored to 'rc' is never read \ > >