Re: [linux-sunxi] [PATCH 2/4] power: add axp20x-battery driver

2016-07-05 Thread Michael Haas
Hi There, On 05.07.2016 10:33, Icenowy Zheng wrote: On 01.07.2016 11:29, Icenowy Zheng wrote: + +static enum power_supply_property axp22x_battery_properties[] = { + POWER_SUPPLY_PROP_CAPACITY, + POWER_SUPPLY_PROP_HEALTH, + POWER_SUPPLY_PROP_PRESENT, + POWER_SUPPLY_PROP_STATUS,

Re: [linux-sunxi] [PATCH 2/4] power: add axp20x-battery driver

2016-07-05 Thread Michael Haas
Hi There, On 05.07.2016 10:33, Icenowy Zheng wrote: On 01.07.2016 11:29, Icenowy Zheng wrote: + +static enum power_supply_property axp22x_battery_properties[] = { + POWER_SUPPLY_PROP_CAPACITY, + POWER_SUPPLY_PROP_HEALTH, + POWER_SUPPLY_PROP_PRESENT, + POWER_SUPPLY_PROP_STATUS,

Re: [linux-sunxi] [PATCH 2/4] power: add axp20x-battery driver

2016-07-05 Thread Bruno Prémont
On Tue, 5 Jul 2016 11:25:10 +0200 Maxime Ripard wrote: > On Tue, Jul 05, 2016 at 04:33:31PM +0800, Icenowy Zheng wrote: > > > > > > 05.07.2016, 13:26, "Michael Haas" : > > > Hi, > > > > > > nice work! Is this in any way related to Bruno Prémonts driver for the > > >

Re: [linux-sunxi] [PATCH 2/4] power: add axp20x-battery driver

2016-07-05 Thread Bruno Prémont
On Tue, 5 Jul 2016 11:25:10 +0200 Maxime Ripard wrote: > On Tue, Jul 05, 2016 at 04:33:31PM +0800, Icenowy Zheng wrote: > > > > > > 05.07.2016, 13:26, "Michael Haas" : > > > Hi, > > > > > > nice work! Is this in any way related to Bruno Prémonts driver for the > > > axp20x? > > > > > > I've

Re: [linux-sunxi] [PATCH 2/4] power: add axp20x-battery driver

2016-07-05 Thread Bruno Prémont
On Tue, 05 Jul 2016 16:47:38 +0800 Icenowy Zheng wrote: > I read the datasheet of axp20x, and then found that this driver does > not support backup RTC battery. > (But maybe backup battery do not need a driver -- at least on IBM PC > it has no driver) A driver is needed to enable/disable the RTC

Re: [linux-sunxi] [PATCH 2/4] power: add axp20x-battery driver

2016-07-05 Thread Bruno Prémont
On Tue, 05 Jul 2016 16:47:38 +0800 Icenowy Zheng wrote: > I read the datasheet of axp20x, and then found that this driver does > not support backup RTC battery. > (But maybe backup battery do not need a driver -- at least on IBM PC > it has no driver) A driver is needed to enable/disable the RTC

Re: [linux-sunxi] [PATCH 2/4] power: add axp20x-battery driver

2016-07-05 Thread maxime.rip...@free-electrons.com
On Tue, Jul 05, 2016 at 04:33:31PM +0800, Icenowy Zheng wrote: > > > 05.07.2016, 13:26, "Michael Haas" : > > Hi, > > > > nice work! Is this in any way related to Bruno Prémonts driver for the > > axp20x? > > > > I've got a reworked version of that lying around, but it's

Re: [linux-sunxi] [PATCH 2/4] power: add axp20x-battery driver

2016-07-05 Thread maxime.rip...@free-electrons.com
On Tue, Jul 05, 2016 at 04:33:31PM +0800, Icenowy Zheng wrote: > > > 05.07.2016, 13:26, "Michael Haas" : > > Hi, > > > > nice work! Is this in any way related to Bruno Prémonts driver for the > > axp20x? > > > > I've got a reworked version of that lying around, but it's not quite > > ready for

Re: [linux-sunxi] [PATCH 2/4] power: add axp20x-battery driver

2016-07-04 Thread Michael Haas
Hi, nice work! Is this in any way related to Bruno Prémonts driver for the axp20x? I've got a reworked version of that lying around, but it's not quite ready for submission. Do you know what pieces are missing in your driver for axp20x support - as opposed to axp22x, which is already

Re: [linux-sunxi] [PATCH 2/4] power: add axp20x-battery driver

2016-07-04 Thread Michael Haas
Hi, nice work! Is this in any way related to Bruno Prémonts driver for the axp20x? I've got a reworked version of that lying around, but it's not quite ready for submission. Do you know what pieces are missing in your driver for axp20x support - as opposed to axp22x, which is already