Re: [linux-sunxi] [PATCH v5 02/20] ASoC: sun4i-i2s: Change set_chan_cfg() params

2020-09-28 Thread Clément Péron
Hi Chen-Yu, On Mon, 28 Sep 2020 at 07:00, Chen-Yu Tsai wrote: > > On Mon, Sep 28, 2020 at 3:29 AM Clément Péron wrote: > > > > As slots and slot_width can be overwritter in case set_tdm() is > > called. Avoid to have this logic in set_chan_cfg(). > > It doesn't seem that set_tdm_slot() would get

Re: [linux-sunxi] [PATCH v5 02/20] ASoC: sun4i-i2s: Change set_chan_cfg() params

2020-09-27 Thread Chen-Yu Tsai
On Mon, Sep 28, 2020 at 3:29 AM Clément Péron wrote: > > As slots and slot_width can be overwritter in case set_tdm() is > called. Avoid to have this logic in set_chan_cfg(). It doesn't seem that set_tdm_slot() would get called concurrently with hw_params(), at least not for the simple-card famil