Re: [linux-sunxi] Re: [PATCH v6] sun4i-codec: Add FM, Line and Mic inputs

Hi Maxime, On Fri, 18 Dec 2015 11:19:43 +0100 Maxime Ripard wrote: > It would also be a good idea to open a github issue on allwinner's > documentation repo to make them know that the register name doesn't > match between the register list and the register documentations. I did that now. the

Re: [linux-sunxi] Re: [PATCH v6] sun4i-codec: Add FM, Line and Mic inputs

Hi Maxime, On Fri, 18 Dec 2015 11:19:43 +0100 Maxime Ripard wrote: > It would also be a good idea to open a github issue on allwinner's > documentation repo to make them know that the register name doesn't > match between the register list and the register

Re: [linux-sunxi] Re: [PATCH v6] sun4i-codec: Add FM, Line and Mic inputs

On Wed, Dec 16, 2015 at 11:30:51PM +0100, Danny Milosavljevic wrote: > Hi Maxime, > > On Wed, 16 Dec 2015 11:47:36 +0100 > Maxime Ripard wrote: > > > > Because SUN4I_CODEC_AC_MIC_PHONE_CAL is sun7i-specific. > > > > Yet, you're using it in both cases (A10 vs A20). > > Yes. I'm trying to keep

Re: [linux-sunxi] Re: [PATCH v6] sun4i-codec: Add FM, Line and Mic inputs

On Wed, Dec 16, 2015 at 11:30:51PM +0100, Danny Milosavljevic wrote: > Hi Maxime, > > On Wed, 16 Dec 2015 11:47:36 +0100 > Maxime Ripard wrote: > > > > Because SUN4I_CODEC_AC_MIC_PHONE_CAL is sun7i-specific. > > > > Yet, you're using it in both cases (A10 vs

Re: [linux-sunxi] Re: [PATCH v6] sun4i-codec: Add FM, Line and Mic inputs

Hi Maxime, On Wed, 16 Dec 2015 11:47:36 +0100 Maxime Ripard wrote: > > Because SUN4I_CODEC_AC_MIC_PHONE_CAL is sun7i-specific. > > Yet, you're using it in both cases (A10 vs A20). Yes. I'm trying to keep complexity and duplication down. I figured it wouldn't be bad to have unused registers in

Re: [linux-sunxi] Re: [PATCH v6] sun4i-codec: Add FM, Line and Mic inputs

Hi Maxime, On Wed, 16 Dec 2015 11:47:36 +0100 Maxime Ripard wrote: > > Because SUN4I_CODEC_AC_MIC_PHONE_CAL is sun7i-specific. > > Yet, you're using it in both cases (A10 vs A20). Yes. I'm trying to keep complexity and duplication down. I figured it wouldn't