Re: [linux-sunxi] Re: [PATCH v8 2/2] ASoc: sun4i-codec: Add FM, Line and Mic inputs

2016-03-22 Thread Stefan Monnier
>> I don't think you should focus too much on alsamixer, there's other >> tools to modify the configuration. > The expectation is that most users will use something like UCM and only > system integrators will see the full control set in normal operation. This presumes the "system integrator"

Re: [linux-sunxi] Re: [PATCH v8 2/2] ASoc: sun4i-codec: Add FM, Line and Mic inputs

2016-03-22 Thread Stefan Monnier
>> I don't think you should focus too much on alsamixer, there's other >> tools to modify the configuration. > The expectation is that most users will use something like UCM and only > system integrators will see the full control set in normal operation. This presumes the "system integrator"

Re: [linux-sunxi] Re: [PATCH v8 2/2] ASoc: sun4i-codec: Add FM, Line and Mic inputs

2016-03-21 Thread Mark Brown
On Mon, Mar 21, 2016 at 07:06:05PM +0100, Maxime Ripard wrote: > I don't think you should focus too much on alsamixer, there's other > tools to modify the configuration. The expectation is that most users will use something like UCM and only system integrators will see the full control set in

Re: [linux-sunxi] Re: [PATCH v8 2/2] ASoc: sun4i-codec: Add FM, Line and Mic inputs

2016-03-21 Thread Mark Brown
On Mon, Mar 21, 2016 at 07:06:05PM +0100, Maxime Ripard wrote: > I don't think you should focus too much on alsamixer, there's other > tools to modify the configuration. The expectation is that most users will use something like UCM and only system integrators will see the full control set in

Re: [linux-sunxi] Re: [PATCH v8 2/2] ASoc: sun4i-codec: Add FM, Line and Mic inputs

2016-03-21 Thread Maxime Ripard
On Sat, Mar 19, 2016 at 05:51:24PM +0100, Danny Milosavljevic wrote: > Hi Maxime, > > > IIRC, in order to have shared controls, you just needed to share the > > controls structure. > > Yeah. I did this and it actually works in a way, but in doesn't do all that I > want. > > There are two

Re: [linux-sunxi] Re: [PATCH v8 2/2] ASoc: sun4i-codec: Add FM, Line and Mic inputs

2016-03-21 Thread Maxime Ripard
On Sat, Mar 19, 2016 at 05:51:24PM +0100, Danny Milosavljevic wrote: > Hi Maxime, > > > IIRC, in order to have shared controls, you just needed to share the > > controls structure. > > Yeah. I did this and it actually works in a way, but in doesn't do all that I > want. > > There are two

Re: [linux-sunxi] Re: [PATCH v8 2/2] ASoc: sun4i-codec: Add FM, Line and Mic inputs

2016-03-21 Thread Maxime Ripard
On Sat, Mar 19, 2016 at 05:13:36PM +0100, Danny Milosavljevic wrote: > Hi Mark, > > my question is whether it's possible to group together the left and > right channel into one selem, and also if it's possible to reuse > volumes then. For example: > > For sun4i-codec Mic there's right now: > -

Re: [linux-sunxi] Re: [PATCH v8 2/2] ASoc: sun4i-codec: Add FM, Line and Mic inputs

2016-03-21 Thread Maxime Ripard
On Sat, Mar 19, 2016 at 05:13:36PM +0100, Danny Milosavljevic wrote: > Hi Mark, > > my question is whether it's possible to group together the left and > right channel into one selem, and also if it's possible to reuse > volumes then. For example: > > For sun4i-codec Mic there's right now: > -

Re: [linux-sunxi] Re: [PATCH v8 2/2] ASoc: sun4i-codec: Add FM, Line and Mic inputs

2016-03-21 Thread Mark Brown
On Sat, Mar 19, 2016 at 05:13:36PM +0100, Danny Milosavljevic wrote: > Hi Mark, > my question is whether it's possible to group together the left and right > channel into one selem, and also if it's possible to reuse volumes then. For > example: Please fix your mail client to word wrap within

Re: [linux-sunxi] Re: [PATCH v8 2/2] ASoc: sun4i-codec: Add FM, Line and Mic inputs

2016-03-21 Thread Mark Brown
On Sat, Mar 19, 2016 at 05:13:36PM +0100, Danny Milosavljevic wrote: > Hi Mark, > my question is whether it's possible to group together the left and right > channel into one selem, and also if it's possible to reuse volumes then. For > example: Please fix your mail client to word wrap within

Re: [linux-sunxi] Re: [PATCH v8 2/2] ASoc: sun4i-codec: Add FM, Line and Mic inputs

2016-03-19 Thread Danny Milosavljevic
Hi Maxime, > IIRC, in order to have shared controls, you just needed to share the > controls structure. Yeah. I did this and it actually works in a way, but in doesn't do all that I want. There are two different kinds of sharing I mean: The one kind with the controls structure causes the

Re: [linux-sunxi] Re: [PATCH v8 2/2] ASoc: sun4i-codec: Add FM, Line and Mic inputs

2016-03-19 Thread Danny Milosavljevic
Hi Maxime, > IIRC, in order to have shared controls, you just needed to share the > controls structure. Yeah. I did this and it actually works in a way, but in doesn't do all that I want. There are two different kinds of sharing I mean: The one kind with the controls structure causes the

Re: [linux-sunxi] Re: [PATCH v8 2/2] ASoc: sun4i-codec: Add FM, Line and Mic inputs

2016-03-19 Thread Danny Milosavljevic
Hi Mark, my question is whether it's possible to group together the left and right channel into one selem, and also if it's possible to reuse volumes then. For example: For sun4i-codec Mic there's right now: - Left Mixer Mic1 Playback Switch - Left Mixer Mic2 Playback Switch - Right Mixer Mic1

Re: [linux-sunxi] Re: [PATCH v8 2/2] ASoc: sun4i-codec: Add FM, Line and Mic inputs

2016-03-19 Thread Danny Milosavljevic
Hi Mark, my question is whether it's possible to group together the left and right channel into one selem, and also if it's possible to reuse volumes then. For example: For sun4i-codec Mic there's right now: - Left Mixer Mic1 Playback Switch - Left Mixer Mic2 Playback Switch - Right Mixer Mic1

Re: [linux-sunxi] Re: [PATCH v8 2/2] ASoc: sun4i-codec: Add FM, Line and Mic inputs

2016-03-15 Thread Mark Brown
On Mon, Mar 14, 2016 at 11:49:39AM +0100, Maxime Ripard wrote: > On Sat, Mar 12, 2016 at 08:52:22AM +0100, Danny Milosavljevic wrote: > > > The other direction (making two controls which both do the same and > > > update > > > each other's value) doesn't seem to be easily available. > > >

Re: [linux-sunxi] Re: [PATCH v8 2/2] ASoc: sun4i-codec: Add FM, Line and Mic inputs

2016-03-15 Thread Mark Brown
On Mon, Mar 14, 2016 at 11:49:39AM +0100, Maxime Ripard wrote: > On Sat, Mar 12, 2016 at 08:52:22AM +0100, Danny Milosavljevic wrote: > > > The other direction (making two controls which both do the same and > > > update > > > each other's value) doesn't seem to be easily available. > > >

Re: [linux-sunxi] Re: [PATCH v8 2/2] ASoc: sun4i-codec: Add FM, Line and Mic inputs

2016-03-14 Thread Maxime Ripard
On Sat, Mar 12, 2016 at 08:52:22AM +0100, Danny Milosavljevic wrote: > Hi, > > does anyone know the answer to the questions below? > > > The other direction (making two controls which both do the same and update > > each other's value) doesn't seem to be easily available. > > > Should I write

Re: [linux-sunxi] Re: [PATCH v8 2/2] ASoc: sun4i-codec: Add FM, Line and Mic inputs

2016-03-14 Thread Maxime Ripard
On Sat, Mar 12, 2016 at 08:52:22AM +0100, Danny Milosavljevic wrote: > Hi, > > does anyone know the answer to the questions below? > > > The other direction (making two controls which both do the same and update > > each other's value) doesn't seem to be easily available. > > > Should I write

Re: [linux-sunxi] Re: [PATCH v8 2/2] ASoc: sun4i-codec: Add FM, Line and Mic inputs

2016-03-12 Thread Code Kipper
Hi Danny, I've got some patches to go which covers pretty much everything that we can manage with the sun4i-codec. I'm only lacking testing of certain bits as I don't have capable hardware(i.e. FM capture). I've ignored the phone out part of the A20 as I couldn't find the pins. I'll try to upload

Re: [linux-sunxi] Re: [PATCH v8 2/2] ASoc: sun4i-codec: Add FM, Line and Mic inputs

2016-03-12 Thread Code Kipper
Hi Danny, I've got some patches to go which covers pretty much everything that we can manage with the sun4i-codec. I'm only lacking testing of certain bits as I don't have capable hardware(i.e. FM capture). I've ignored the phone out part of the A20 as I couldn't find the pins. I'll try to upload

Re: [linux-sunxi] Re: [PATCH v8 2/2] ASoc: sun4i-codec: Add FM, Line and Mic inputs

2016-03-11 Thread Danny Milosavljevic
Hi, does anyone know the answer to the questions below? > The other direction (making two controls which both do the same and update > each other's value) doesn't seem to be easily available. > Should I write a _put handler that does it manually? > (Or should that be handled by alsa-lib

Re: [linux-sunxi] Re: [PATCH v8 2/2] ASoc: sun4i-codec: Add FM, Line and Mic inputs

2016-03-11 Thread Danny Milosavljevic
Hi, does anyone know the answer to the questions below? > The other direction (making two controls which both do the same and update > each other's value) doesn't seem to be easily available. > Should I write a _put handler that does it manually? > (Or should that be handled by alsa-lib

Re: [linux-sunxi] Re: [PATCH v8 2/2] ASoc: sun4i-codec: Add FM, Line and Mic inputs

2016-01-06 Thread Maxime Ripard
On Mon, Dec 28, 2015 at 04:06:49AM +0100, Danny Milosavljevic wrote: > Hi Maxime, > > On Sun, 27 Dec 2015 19:21:57 +0100 > Maxime Ripard wrote: > > > On Mon, Dec 21, 2015 at 12:34:16PM +0100, Danny Milosavljevic wrote: > > > This is the second part, actually adding FM, Line and Mic inputs. > >

Re: [linux-sunxi] Re: [PATCH v8 2/2] ASoc: sun4i-codec: Add FM, Line and Mic inputs

2016-01-06 Thread Maxime Ripard
On Mon, Dec 28, 2015 at 04:06:49AM +0100, Danny Milosavljevic wrote: > Hi Maxime, > > On Sun, 27 Dec 2015 19:21:57 +0100 > Maxime Ripard wrote: > > > On Mon, Dec 21, 2015 at 12:34:16PM +0100, Danny Milosavljevic wrote: > > > This is the second part, actually

Re: [linux-sunxi] Re: [PATCH v8 2/2] ASoc: sun4i-codec: Add FM, Line and Mic inputs

2015-12-31 Thread Mark Brown
On Mon, Dec 28, 2015 at 04:06:49AM +0100, Danny Milosavljevic wrote: > Maxime Ripard wrote: > > > +static SOC_ENUM_SINGLE_DECL(sun4i_codec_enum_capture_source, > > > + SUN4I_CODEC_ADC_ACTL, > > > + SUN4I_CODEC_ADC_ACTL_ADCIS, > > > +

Re: [linux-sunxi] Re: [PATCH v8 2/2] ASoc: sun4i-codec: Add FM, Line and Mic inputs

2015-12-31 Thread Mark Brown
On Mon, Dec 28, 2015 at 04:06:49AM +0100, Danny Milosavljevic wrote: > Maxime Ripard wrote: > > > +static SOC_ENUM_SINGLE_DECL(sun4i_codec_enum_capture_source, > > > + SUN4I_CODEC_ADC_ACTL, > > > +

Re: [linux-sunxi] Re: [PATCH v8 2/2] ASoc: sun4i-codec: Add FM, Line and Mic inputs

2015-12-27 Thread Danny Milosavljevic
Hi Maxime, On Sun, 27 Dec 2015 19:21:57 +0100 Maxime Ripard wrote: > On Mon, Dec 21, 2015 at 12:34:16PM +0100, Danny Milosavljevic wrote: > > This is the second part, actually adding FM, Line and Mic inputs. > > Again, having a meaningful and standalone commit log would be nice. Okay, will

Re: [linux-sunxi] Re: [PATCH v8 2/2] ASoc: sun4i-codec: Add FM, Line and Mic inputs

2015-12-27 Thread Danny Milosavljevic
Hi Maxime, On Sun, 27 Dec 2015 19:21:57 +0100 Maxime Ripard wrote: > On Mon, Dec 21, 2015 at 12:34:16PM +0100, Danny Milosavljevic wrote: > > This is the second part, actually adding FM, Line and Mic inputs. > > Again, having a meaningful and standalone commit