On Sun, May 24, 2015 at 10:04:16AM +0200, Corentin LABBE wrote:
>
> For aes_cbc it exists a test with 3 SG with .tap = { 496 - 20, 4, 16 }
> But my driver handle that. (multiple of 4)
>
> What do you think about adding a test with 16 SG of 1 byte ? (or 3 + 2 + 3 +
> 8 * 1)
Sure please send a
Le 24/05/2015 05:32, Herbert Xu a écrit :
> On Sat, May 23, 2015 at 04:35:36PM +0200, Boris Brezillon wrote:
>>
>>> Since all SG I get was always a multiple of 16 (AES BLOCK SIZE) it was a
>>> sort of confirmation.
>>>
>>> Herbert ? does am I right or a chunking test is missing for cbc(aes) in
Le 24/05/2015 05:32, Herbert Xu a écrit :
On Sat, May 23, 2015 at 04:35:36PM +0200, Boris Brezillon wrote:
Since all SG I get was always a multiple of 16 (AES BLOCK SIZE) it was a
sort of confirmation.
Herbert ? does am I right or a chunking test is missing for cbc(aes) in
testmgr.h
On Sun, May 24, 2015 at 10:04:16AM +0200, Corentin LABBE wrote:
For aes_cbc it exists a test with 3 SG with .tap = { 496 - 20, 4, 16 }
But my driver handle that. (multiple of 4)
What do you think about adding a test with 16 SG of 1 byte ? (or 3 + 2 + 3 +
8 * 1)
Sure please send a patch.
On Sat, May 23, 2015 at 02:18:06PM +0200, Corentin LABBE wrote:
>
> What do you think about adding a BUG_ON(in_atomic()) in
> crypto_ablkcipher_setkey() ?
Just add a might_sleep() to it.
Thanks,
--
Email: Herbert Xu
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key:
Le 15/05/2015 08:49, Herbert Xu a écrit :
> On Thu, May 14, 2015 at 02:59:01PM +0200, LABBE Corentin wrote:
>>
>> +err = crypto_ablkcipher_setkey(op->fallback, kkey, op->keylen);
>> +if (err != 0) {
>> +dev_err(ss->dev, "Cannot set key on fallback\n");
>> +return
Le 15/05/2015 08:49, Herbert Xu a écrit :
On Thu, May 14, 2015 at 02:59:01PM +0200, LABBE Corentin wrote:
+err = crypto_ablkcipher_setkey(op-fallback, kkey, op-keylen);
+if (err != 0) {
+dev_err(ss-dev, Cannot set key on fallback\n);
+return -EINVAL;
+}
On Sat, May 23, 2015 at 02:18:06PM +0200, Corentin LABBE wrote:
What do you think about adding a BUG_ON(in_atomic()) in
crypto_ablkcipher_setkey() ?
Just add a might_sleep() to it.
Thanks,
--
Email: Herbert Xu herb...@gondor.apana.org.au
Home Page: http://gondor.apana.org.au/~herbert/
PGP
On Sat, May 16, 2015 at 08:09:27PM +0200, Corentin LABBE wrote:
>
> Incidental question, I need to use the MD5 IV for export_md5 function, but
> they are not defined anywhere (unlike SHAxx ones), does this is voluntary or
> do you will accept a patch for adding them.
Please send a patch to add
Le 15/05/2015 08:52, Herbert Xu a écrit :
> On Thu, May 14, 2015 at 02:59:01PM +0200, LABBE Corentin wrote:
>>
>> +int sun4i_hash_export(struct ahash_request *areq, void *out)
>> +{
>> +struct sun4i_req_ctx *op = ahash_request_ctx(areq);
>> +
>> +memcpy(out, op, sizeof(struct
Le 15/05/2015 08:52, Herbert Xu a écrit :
On Thu, May 14, 2015 at 02:59:01PM +0200, LABBE Corentin wrote:
+int sun4i_hash_export(struct ahash_request *areq, void *out)
+{
+struct sun4i_req_ctx *op = ahash_request_ctx(areq);
+
+memcpy(out, op, sizeof(struct sun4i_req_ctx));
+
On Sat, May 16, 2015 at 08:09:27PM +0200, Corentin LABBE wrote:
Incidental question, I need to use the MD5 IV for export_md5 function, but
they are not defined anywhere (unlike SHAxx ones), does this is voluntary or
do you will accept a patch for adding them.
Please send a patch to add
12 matches
Mail list logo