Re: [linux-usb-devel] [PATCH] Fix NEC OHCI chip silicon bug

2007-06-06 Thread Alan Stern
On Wed, 6 Jun 2007, Michael Hanselmann wrote: > > So the system is behaving the way you want, but not for the reason you > > think. I bet you could remove the call to usb_root_hub_lost_power() > > entirely and it wouldn't make any difference at all. > > Actually, that's true. René Nussbaumer

Re: [linux-usb-devel] [PATCH] Fix NEC OHCI chip silicon bug

2007-06-06 Thread Michael Hanselmann
On Tue, Jun 05, 2007 at 10:24:14AM -0400, Alan Stern wrote: > (Depending on which version of the kernel you are looking at -- [...] > Earlier versions did behave the way you describe.) I was looking at 2.6.22-rc3 which might explain the differences. > So the system is behaving the way you want, b

Re: [linux-usb-devel] [PATCH] Fix NEC OHCI chip silicon bug

2007-06-05 Thread Alan Stern
On Mon, 4 Jun 2007, Michael Hanselmann wrote: > On Sat, Jun 02, 2007 at 10:49:44AM -0400, Alan Stern wrote: > > Then later on, when the hub driver is resumed it will see the flag and > > disconnect all the devices below the root hub. > > > For instance, you could force ohci-hcd to report connect-

Re: [linux-usb-devel] [PATCH] Fix NEC OHCI chip silicon bug

2007-06-04 Thread Michael Hanselmann
On Sat, Jun 02, 2007 at 10:49:44AM -0400, Alan Stern wrote: > Then later on, when the hub driver is resumed it will see the flag and > disconnect all the devices below the root hub. > For instance, you could force ohci-hcd to report connect-change events > on all the ports. Perhaps it does somethi

Re: [linux-usb-devel] [PATCH] Fix NEC OHCI chip silicon bug

2007-06-02 Thread Alan Stern
On Sat, 2 Jun 2007, Michael Hanselmann wrote: > On Fri, Jun 01, 2007 at 10:19:30AM -0400, Alan Stern wrote: > > > @@ -779,7 +790,11 @@ static int ohci_restart (struct ohci_hcd > > >*/ > > > spin_lock_irq(&ohci->lock); > > > disable (ohci); > > > + > > > +#ifdef CONFIG_PM > > > usb_root_h

Re: [linux-usb-devel] [PATCH] Fix NEC OHCI chip silicon bug

2007-06-02 Thread Michael Hanselmann
On Fri, Jun 01, 2007 at 10:19:30AM -0400, Alan Stern wrote: > > @@ -779,7 +790,11 @@ static int ohci_restart (struct ohci_hcd > > */ > > spin_lock_irq(&ohci->lock); > > disable (ohci); > > + > > +#ifdef CONFIG_PM > > usb_root_hub_lost_power(ohci_to_hcd(ohci)->self.root_hub); > > +#

Re: [linux-usb-devel] [PATCH] Fix NEC OHCI chip silicon bug

2007-06-01 Thread Alan Stern
On Thu, 31 May 2007, Michael Hanselmann wrote: > This patch fixes a silicon bug in some NEC OHCI chips. The bug appears > at random times and is very, very difficult to reproduce. Without the > following patch, Linux would shut the chip and its associated devices > down. In Apple PowerBooks this l