Re: [linux-usb-devel] [PATCH] base/class.c: prevent ooops due to insert/remove race (v3)

2007-11-29 Thread Alan Stern
On Thu, 29 Nov 2007, Linus Torvalds wrote: > Heh. It definitely hasn't gotten lost by "the git software". No, it sure hasn't. In fact it was staring me right in the face and I didn't realize it. > In fact, with > the kinds of hints you already gave, git makes it really _trivial_ to find > it

Re: [linux-usb-devel] [PATCH] base/class.c: prevent ooops due to insert/remove race (v3)

2007-11-29 Thread Linus Torvalds
On Thu, 29 Nov 2007, Alan Stern wrote: > > Yes indeed. I wish I could point you to the exact patch containing the > fix, but the git software seems to have lost track of it (it's combined > in with a large number of other patches with no obvious way to separate > it out). It's also available

Re: [linux-usb-devel] [PATCH] base/class.c: prevent ooops due to insert/remove race (v3)

2007-11-29 Thread Alan Stern
On Thu, 29 Nov 2007, Mark Lord wrote: > Alan Stern wrote: > > On Thu, 29 Nov 2007, Mark Lord wrote: > > > >>> So again, the problem is in the higher up scsi layer, and that is where > >>> the problem should already be fixed. > >> .. > >> > >> Ahhh.. so you figure the Oops should also have been fi

Re: [linux-usb-devel] [PATCH] base/class.c: prevent ooops due to insert/remove race (v3)

2007-11-29 Thread Greg KH
On Thu, Nov 29, 2007 at 05:07:58PM -0500, Alan Stern wrote: > On Thu, 29 Nov 2007, Mark Lord wrote: > > > > So again, the problem is in the higher up scsi layer, and that is where > > > the problem should already be fixed. > > .. > > > > Ahhh.. so you figure the Oops should also have been fixed >

Re: [linux-usb-devel] [PATCH] base/class.c: prevent ooops due to insert/remove race (v3)

2007-11-29 Thread Mark Lord
Alan Stern wrote: On Thu, 29 Nov 2007, Mark Lord wrote: So again, the problem is in the higher up scsi layer, and that is where the problem should already be fixed. .. Ahhh.. so you figure the Oops should also have been fixed as part of the 2.6.24 SCSI fixes ? That's what I was missing here.

Re: [linux-usb-devel] [PATCH] base/class.c: prevent ooops due to insert/remove race (v3)

2007-11-29 Thread Alan Stern
On Thu, 29 Nov 2007, Mark Lord wrote: > > So again, the problem is in the higher up scsi layer, and that is where > > the problem should already be fixed. > .. > > Ahhh.. so you figure the Oops should also have been fixed > as part of the 2.6.24 SCSI fixes ? That's what I was missing here. Yes

Re: [linux-usb-devel] [PATCH] base/class.c: prevent ooops due to insert/remove race (v3)

2007-11-29 Thread Alan Stern
On Thu, 29 Nov 2007, Mark Lord wrote: > (resending with condensed version of original syslog) (Sending a 344-KB log file wasn't enough, you had to send another 46-KB condensed version as well? :-) > Alan Stern wrote: > > On Thu, 29 Nov 2007, Mark Lord wrote: > > > >> But the flogging continues

Re: [linux-usb-devel] [PATCH] base/class.c: prevent ooops due to insert/remove race (v3)

2007-11-29 Thread Greg KH
On Thu, Nov 29, 2007 at 03:46:42PM -0500, Mark Lord wrote: > Greg KH wrote: >> So again, the problem is in the higher up scsi layer, and that is where >> the problem should already be fixed. > .. > > Ahhh.. so you figure the Oops should also have been fixed > as part of the 2.6.24 SCSI fixes ? Tha

Re: [linux-usb-devel] [PATCH] base/class.c: prevent ooops due to insert/remove race (v3)

2007-11-29 Thread Mark Lord
Greg KH wrote: On Thu, Nov 29, 2007 at 03:25:04PM -0500, Mark Lord wrote: (resending .. somebody trimmed the CC: list earlier) Greg KH wrote: Mark Lord wrote: .. While doing insert/remove (quickly) tests on USB, I managed to trigger an Oops on 2.6.23.8 on a call to strlen() in make_class_nam

Re: [linux-usb-devel] [PATCH] base/class.c: prevent ooops due to insert/remove race (v3)

2007-11-29 Thread Greg KH
On Thu, Nov 29, 2007 at 03:25:04PM -0500, Mark Lord wrote: > (resending .. somebody trimmed the CC: list earlier) > > Greg KH wrote: > Mark Lord wrote: >> .. >> >> While doing insert/remove (quickly) tests on USB, >> I managed to trigger an Oops on 2.6.23.8 on a call >> to s

Re: [linux-usb-devel] [PATCH] base/class.c: prevent ooops due to insert/remove race (v3)

2007-11-29 Thread Mark Lord
(resending .. somebody trimmed the CC: list earlier) Greg KH wrote: Mark Lord wrote: .. While doing insert/remove (quickly) tests on USB, I managed to trigger an Oops on 2.6.23.8 on a call to strlen() in make_class_name(). ... I'll hold off on adding this patch for now. .. Why? Bugs that

Re: [linux-usb-devel] [PATCH] base/class.c: prevent ooops due to insert/remove race (v3)

2007-11-29 Thread Mark Lord
(resending with condensed version of original syslog) Alan Stern wrote: On Thu, 29 Nov 2007, Mark Lord wrote: But the flogging continues multiple times per second until the system is shutdown, so it is "the next bug to fix". That's not true. The number of commands sent while probing a devic

Re: [linux-usb-devel] [PATCH] base/class.c: prevent ooops due to insert/remove race (v3)

2007-11-29 Thread Alan Stern
On Thu, 29 Nov 2007, Mark Lord wrote: > But the flogging continues multiple times per second > until the system is shutdown, so it is "the next bug to fix". That's not true. The number of commands sent while probing a device is predetermined and strictly limited. In any case, what you're talkin

Re: [linux-usb-devel] [PATCH] base/class.c: prevent ooops due to insert/remove race (v3)

2007-11-29 Thread Greg KH
On Thu, Nov 29, 2007 at 03:01:48PM -0500, Mark Lord wrote: > Alan Stern wrote: >> On Thu, 29 Nov 2007, Mark Lord wrote: >>> Mark Lord wrote: .. While doing insert/remove (quickly) tests on USB, I managed to trigger an Oops on 2.6.23.8 on a call to strlen() in make_class_nam

Re: [linux-usb-devel] [PATCH] base/class.c: prevent ooops due to insert/remove race (v3)

2007-11-29 Thread Mark Lord
Alan Stern wrote: On Thu, 29 Nov 2007, Mark Lord wrote: Mark Lord wrote: .. While doing insert/remove (quickly) tests on USB, I managed to trigger an Oops on 2.6.23.8 on a call to strlen() in make_class_name(). Does this oops occur under 2.6.24? The SCSI async scanning code was changed bet

Re: [linux-usb-devel] [PATCH] base/class.c: prevent ooops due to insert/remove race (v3)

2007-11-29 Thread Alan Stern
On Thu, 29 Nov 2007, Mark Lord wrote: > Mark Lord wrote: > > .. > > > > While doing insert/remove (quickly) tests on USB, > > I managed to trigger an Oops on 2.6.23.8 on a call > > to strlen() in make_class_name(). Does this oops occur under 2.6.24? The SCSI async scanning code was changed betw