Re: [lkp-robot] [x86/refcount] b631e535c6: WARNING:at_net/netlink/af_netlink.c:#netlink_sock_destruct

2017-07-27 Thread Hans Liljestrand
On Tue, Jul 25, 2017 at 11:38:30AM -0700, Kees Cook wrote: On Tue, Jul 25, 2017 at 3:43 AM, Hans Liljestrand wrote: On Mon, Jul 24, 2017 at 08:21:16PM -0700, Kees Cook wrote: On Mon, Jul 24, 2017 at 6:03 AM, Hans Liljestrand wrote: On Sun, Jul 23, 2017 at 08:52:53PM -0700, Kees Cook wrote:

Re: [lkp-robot] [x86/refcount] b631e535c6: WARNING:at_net/netlink/af_netlink.c:#netlink_sock_destruct

2017-07-25 Thread Kees Cook
On Tue, Jul 25, 2017 at 3:43 AM, Hans Liljestrand wrote: > On Mon, Jul 24, 2017 at 08:21:16PM -0700, Kees Cook wrote: >> >> On Mon, Jul 24, 2017 at 6:03 AM, Hans Liljestrand >> wrote: >>> >>> On Sun, Jul 23, 2017 at 08:52:53PM -0700, Kees Cook wrote: Is 14afee4b6092f ("net: convert

Re: [lkp-robot] [x86/refcount] b631e535c6: WARNING:at_net/netlink/af_netlink.c:#netlink_sock_destruct

2017-07-25 Thread Hans Liljestrand
On Mon, Jul 24, 2017 at 08:21:16PM -0700, Kees Cook wrote: On Mon, Jul 24, 2017 at 6:03 AM, Hans Liljestrand wrote: On Sun, Jul 23, 2017 at 08:52:53PM -0700, Kees Cook wrote: Is 14afee4b6092f ("net: convert sock.sk_wmem_alloc from atomic_t to refcount_t") correct? That looks like a statistics

Re: [lkp-robot] [x86/refcount] b631e535c6: WARNING:at_net/netlink/af_netlink.c:#netlink_sock_destruct

2017-07-24 Thread Kees Cook
On Mon, Jul 24, 2017 at 6:03 AM, Hans Liljestrand wrote: > On Sun, Jul 23, 2017 at 08:52:53PM -0700, Kees Cook wrote: >> >> Is 14afee4b6092f ("net: convert sock.sk_wmem_alloc from atomic_t to >> refcount_t") correct? That looks like a statistics counter, not a >> refcounter? I can't quite tell, th

Re: [lkp-robot] [x86/refcount] b631e535c6: WARNING:at_net/netlink/af_netlink.c:#netlink_sock_destruct

2017-07-24 Thread Hans Liljestrand
On Sun, Jul 23, 2017 at 08:52:53PM -0700, Kees Cook wrote: Is 14afee4b6092f ("net: convert sock.sk_wmem_alloc from atomic_t to refcount_t") correct? That looks like a statistics counter, not a refcounter? I can't quite tell, though... Hmm, yes, it looks a bit weird, but it is used in a refcount

Re: [lkp-robot] [x86/refcount] b631e535c6: WARNING:at_net/netlink/af_netlink.c:#netlink_sock_destruct

2017-07-23 Thread Kees Cook
Is 14afee4b6092f ("net: convert sock.sk_wmem_alloc from atomic_t to refcount_t") correct? That looks like a statistics counter, not a refcounter? I can't quite tell, though... I think this WARN is from: WARN_ON(refcount_read(&sk->sk_wmem_alloc)); -Kees On Sun, Jul 23, 2017 at 7:13 PM, kernel te

[lkp-robot] [x86/refcount] b631e535c6: WARNING:at_net/netlink/af_netlink.c:#netlink_sock_destruct

2017-07-23 Thread kernel test robot
FYI, we noticed the following commit: commit: b631e535c61d7ddbb7ebac545f729ca9b3b6d70e ("x86/refcount: Implement fast refcount overflow protection") https://git.kernel.org/cgit/linux/kernel/git/kees/linux.git kspp/fast-refcount/ud/v6 in testcase: boot on test machine: qemu-system-x86_64 -enab