Re: [lustre-devel] [PATCH 3/6] staging: lustre: obdclass: Create a header for obdo related functions

2016-12-07 Thread James Simmons
> Sorry, I was unclear. I have no problem with white space changes on > their own or when they are on the same line as something else you're > changing. > > What I meant is that when you're just moving functions around then don't > mix unrelated white space changes into that patch. I have autom

Re: [lustre-devel] [PATCH 3/6] staging: lustre: obdclass: Create a header for obdo related functions

2016-12-05 Thread Dan Carpenter
Sorry, I was unclear. I have no problem with white space changes on their own or when they are on the same line as something else you're changing. What I meant is that when you're just moving functions around then don't mix unrelated white space changes into that patch. I have automated scripts

Re: [lustre-devel] [PATCH 3/6] staging: lustre: obdclass: Create a header for obdo related functions

2016-12-05 Thread Dilger, Andreas
> On Dec 5, 2016, at 13:50, Dan Carpenter wrote: > > On Fri, Dec 02, 2016 at 02:40:47PM -0500, James Simmons wrote: >> -__u32 local_flags = 0; >> +u32 local_flags = 0; > >> -if (local_flags != 0) { >> +if (local_flags) { > > Please avoid these unrelated white space changes. So