Re: [lvc-project] [PATCH] remoteproc: imx_rproc: Adjust phandle parsing issue while remapping optional addresses in imx_rproc_addr_init()

2024-06-12 Thread Aleksandr Mishin
On 11.06.2024 19:45, Mathieu Poirier wrote: On Mon, Jun 10, 2024 at 08:36:19PM +0300, Fedor Pchelkin wrote: On Mon, 10. Jun 10:47, Mathieu Poirier wrote: On Thu, Jun 06, 2024 at 10:52:04AM +0300, Aleksandr Mishin wrote: In imx_rproc_addr_init() "nph = of_count_phandle_with_args()" just

Re: [lvc-project] [PATCH] remoteproc: imx_rproc: Adjust phandle parsing issue while remapping optional addresses in imx_rproc_addr_init()

2024-06-12 Thread Fedor Pchelkin
On Tue, 11. Jun 10:45, Mathieu Poirier wrote: > On Mon, Jun 10, 2024 at 08:36:19PM +0300, Fedor Pchelkin wrote: > > Btw, there is a "rsc-table" node->name check in the the end of the loop > > body. It was added recently with commit 5e4c1243071d ("remoteproc: > > imx_rproc: support remote cores

Re: [lvc-project] [PATCH] remoteproc: imx_rproc: Adjust phandle parsing issue while remapping optional addresses in imx_rproc_addr_init()

2024-06-11 Thread Mathieu Poirier
On Mon, Jun 10, 2024 at 08:36:19PM +0300, Fedor Pchelkin wrote: > On Mon, 10. Jun 10:47, Mathieu Poirier wrote: > > On Thu, Jun 06, 2024 at 10:52:04AM +0300, Aleksandr Mishin wrote: > > > In imx_rproc_addr_init() "nph = of_count_phandle_with_args()" just counts > > > number of phandles. But

Re: [lvc-project] [PATCH] remoteproc: imx_rproc: Adjust phandle parsing issue while remapping optional addresses in imx_rproc_addr_init()

2024-06-10 Thread Fedor Pchelkin
On Mon, 10. Jun 10:47, Mathieu Poirier wrote: > On Thu, Jun 06, 2024 at 10:52:04AM +0300, Aleksandr Mishin wrote: > > In imx_rproc_addr_init() "nph = of_count_phandle_with_args()" just counts > > number of phandles. But phandles may be empty. So of_parse_phandle() in > > the parsing loop (0 < a <