Re: [mm patch] i915: fix invalid opcode exception on cpus without clflush

2008-01-17 Thread Kyle McMartin
On Thu, Jan 17, 2008 at 09:03:17PM -0500, H. Peter Anvin wrote: > The #ifdef is bogus. If it's required, it should go into > asm-x86/required_features.h and then cpu_has_clflush is static; otherwise > it's just plain wrong. > I have no objection to making cpu_has_clflush constant on x86_64. The

Re: [mm patch] i915: fix invalid opcode exception on cpus without clflush

2008-01-17 Thread Harvey Harrison
On Thu, 2008-01-17 at 21:03 -0500, H. Peter Anvin wrote: > Kyle McMartin wrote: > > i915_flush_ttm was unconditionally executing a clflush instruction > > to (obviously) flush the cache. Instead, check if the cpu supports > > clflush, and if not, fall back to calling wbinvd to flush the entire > >

Re: [mm patch] i915: fix invalid opcode exception on cpus without clflush

2008-01-17 Thread H. Peter Anvin
Kyle McMartin wrote: i915_flush_ttm was unconditionally executing a clflush instruction to (obviously) flush the cache. Instead, check if the cpu supports clflush, and if not, fall back to calling wbinvd to flush the entire cache. Signed-off-by: Kyle McMartin <[EMAIL PROTECTED]> --- a/drivers/c

[mm patch] i915: fix invalid opcode exception on cpus without clflush

2008-01-17 Thread Kyle McMartin
i915_flush_ttm was unconditionally executing a clflush instruction to (obviously) flush the cache. Instead, check if the cpu supports clflush, and if not, fall back to calling wbinvd to flush the entire cache. Signed-off-by: Kyle McMartin <[EMAIL PROTECTED]> --- a/drivers/char/drm/i915_buffer.c +