Re: [mmotm] "x86/atomic: move __arch_atomic_add_unless out of line" build error

2017-03-16 Thread Andrew Morton
On Thu, 16 Mar 2017 09:41:10 -0700 Andi Kleen wrote: > > Andi, why did you completely remove __arch_atomic_add_unless() from > > the header? Don't we need at least a declaration there? > > Actually it's there in my git version: > > I wonder where it disappeared. > > -/**

Re: [mmotm] "x86/atomic: move __arch_atomic_add_unless out of line" build error

2017-03-16 Thread Andrew Morton
On Thu, 16 Mar 2017 09:41:10 -0700 Andi Kleen wrote: > > Andi, why did you completely remove __arch_atomic_add_unless() from > > the header? Don't we need at least a declaration there? > > Actually it's there in my git version: > > I wonder where it disappeared. > > -/** > - *

Re: [mmotm] "x86/atomic: move __arch_atomic_add_unless out of line" build error

2017-03-16 Thread Andi Kleen
> Andi, why did you completely remove __arch_atomic_add_unless() from > the header? Don't we need at least a declaration there? Actually it's there in my git version: I wonder where it disappeared. -/** - * __atomic_add_unless - add unless the number is already a given value - * @v: pointer of

Re: [mmotm] "x86/atomic: move __arch_atomic_add_unless out of line" build error

2017-03-16 Thread Andi Kleen
> Andi, why did you completely remove __arch_atomic_add_unless() from > the header? Don't we need at least a declaration there? Actually it's there in my git version: I wonder where it disappeared. -/** - * __atomic_add_unless - add unless the number is already a given value - * @v: pointer of

Re: [mmotm] "x86/atomic: move __arch_atomic_add_unless out of line" build error

2017-03-16 Thread Andi Kleen
> Andi, why did you completely remove __arch_atomic_add_unless() from > the header? Don't we need at least a declaration there? Yes the declaration should be there. I'll send a new patch. -Andi

Re: [mmotm] "x86/atomic: move __arch_atomic_add_unless out of line" build error

2017-03-16 Thread Andi Kleen
> Andi, why did you completely remove __arch_atomic_add_unless() from > the header? Don't we need at least a declaration there? Yes the declaration should be there. I'll send a new patch. -Andi

Re: [mmotm] "x86/atomic: move __arch_atomic_add_unless out of line" build error

2017-03-16 Thread Dmitry Vyukov
On Thu, Mar 16, 2017 at 5:47 AM, Sergey Senozhatsky wrote: > Hello, > > commit 4f86a82ff7df ("x86/atomic: move __arch_atomic_add_unless out of line") > moved __arch_atomic_add_unless() out atomic.h and new KASAN atomic > instrumentation [1] can't see it anymore

Re: [mmotm] "x86/atomic: move __arch_atomic_add_unless out of line" build error

2017-03-16 Thread Dmitry Vyukov
On Thu, Mar 16, 2017 at 5:47 AM, Sergey Senozhatsky wrote: > Hello, > > commit 4f86a82ff7df ("x86/atomic: move __arch_atomic_add_unless out of line") > moved __arch_atomic_add_unless() out atomic.h and new KASAN atomic > instrumentation [1] can't see it anymore > > > In file included from

[mmotm] "x86/atomic: move __arch_atomic_add_unless out of line" build error

2017-03-15 Thread Sergey Senozhatsky
Hello, commit 4f86a82ff7df ("x86/atomic: move __arch_atomic_add_unless out of line") moved __arch_atomic_add_unless() out atomic.h and new KASAN atomic instrumentation [1] can't see it anymore In file included from ./arch/x86/include/asm/atomic.h:257:0, from

[mmotm] "x86/atomic: move __arch_atomic_add_unless out of line" build error

2017-03-15 Thread Sergey Senozhatsky
Hello, commit 4f86a82ff7df ("x86/atomic: move __arch_atomic_add_unless out of line") moved __arch_atomic_add_unless() out atomic.h and new KASAN atomic instrumentation [1] can't see it anymore In file included from ./arch/x86/include/asm/atomic.h:257:0, from