Re: [net-next][PATCH v2 18/18] RDS: IB: add missing connection cache usage info

On 12/7/2016 9:36 AM, David Miller wrote: [...] What does the newer tool do on an older kernel if it doesn't see the fields? Does it check the size of the structure given back to it, and conditionally handle the older vs. the newer layout? It must do this. Right but the rds-tool doesn't

Re: [net-next][PATCH v2 18/18] RDS: IB: add missing connection cache usage info

On 12/7/2016 9:36 AM, David Miller wrote: [...] What does the newer tool do on an older kernel if it doesn't see the fields? Does it check the size of the structure given back to it, and conditionally handle the older vs. the newer layout? It must do this. Right but the rds-tool doesn't

Re: [net-next][PATCH v2 18/18] RDS: IB: add missing connection cache usage info

From: Santosh Shilimkar Date: Wed, 7 Dec 2016 09:20:17 -0800 > Newer/Updated tools which can parse this extra info in needs newer > or an updated kernel which supports and populates these fields. > > As mentioned, this particular option used only in verbose mode so

Re: [net-next][PATCH v2 18/18] RDS: IB: add missing connection cache usage info

From: Santosh Shilimkar Date: Wed, 7 Dec 2016 09:20:17 -0800 > Newer/Updated tools which can parse this extra info in needs newer > or an updated kernel which supports and populates these fields. > > As mentioned, this particular option used only in verbose mode so > am ok to drop this change

Re: [net-next][PATCH v2 18/18] RDS: IB: add missing connection cache usage info

On 12/7/2016 9:05 AM, David Miller wrote: From: Santosh Shilimkar Date: Wed, 7 Dec 2016 08:44:04 -0800 On 12/7/2016 7:55 AM, David Miller wrote: From: Santosh Shilimkar Date: Tue, 6 Dec 2016 20:01:56 -0800 What level of

Re: [net-next][PATCH v2 18/18] RDS: IB: add missing connection cache usage info

On 12/7/2016 9:05 AM, David Miller wrote: From: Santosh Shilimkar Date: Wed, 7 Dec 2016 08:44:04 -0800 On 12/7/2016 7:55 AM, David Miller wrote: From: Santosh Shilimkar Date: Tue, 6 Dec 2016 20:01:56 -0800 What level of compatability exists here? If we run an old tool on a new kernel, or

Re: [net-next][PATCH v2 18/18] RDS: IB: add missing connection cache usage info

From: Santosh Shilimkar Date: Wed, 7 Dec 2016 08:44:04 -0800 > On 12/7/2016 7:55 AM, David Miller wrote: >> From: Santosh Shilimkar >> Date: Tue, 6 Dec 2016 20:01:56 -0800 >> >> What level of compatability exists here? If we run an

Re: [net-next][PATCH v2 18/18] RDS: IB: add missing connection cache usage info

From: Santosh Shilimkar Date: Wed, 7 Dec 2016 08:44:04 -0800 > On 12/7/2016 7:55 AM, David Miller wrote: >> From: Santosh Shilimkar >> Date: Tue, 6 Dec 2016 20:01:56 -0800 >> >> What level of compatability exists here? If we run an old tool on a >> new >> kernel, or a new tool on an old

Re: [net-next][PATCH v2 18/18] RDS: IB: add missing connection cache usage info

On 12/7/2016 7:55 AM, David Miller wrote: From: Santosh Shilimkar Date: Tue, 6 Dec 2016 20:01:56 -0800 rds-tools already support it. Signed-off-by: Santosh Shilimkar --- include/uapi/linux/rds.h | 1 + net/rds/ib.c |

Re: [net-next][PATCH v2 18/18] RDS: IB: add missing connection cache usage info

On 12/7/2016 7:55 AM, David Miller wrote: From: Santosh Shilimkar Date: Tue, 6 Dec 2016 20:01:56 -0800 rds-tools already support it. Signed-off-by: Santosh Shilimkar --- include/uapi/linux/rds.h | 1 + net/rds/ib.c | 1 + 2 files changed, 2 insertions(+) diff --git

Re: [net-next][PATCH v2 18/18] RDS: IB: add missing connection cache usage info

From: Santosh Shilimkar Date: Tue, 6 Dec 2016 20:01:56 -0800 > rds-tools already support it. > > Signed-off-by: Santosh Shilimkar > --- > include/uapi/linux/rds.h | 1 + > net/rds/ib.c | 1 + > 2 files changed, 2

Re: [net-next][PATCH v2 18/18] RDS: IB: add missing connection cache usage info

From: Santosh Shilimkar Date: Tue, 6 Dec 2016 20:01:56 -0800 > rds-tools already support it. > > Signed-off-by: Santosh Shilimkar > --- > include/uapi/linux/rds.h | 1 + > net/rds/ib.c | 1 + > 2 files changed, 2 insertions(+) > > diff --git a/include/uapi/linux/rds.h

[net-next][PATCH v2 18/18] RDS: IB: add missing connection cache usage info

rds-tools already support it. Signed-off-by: Santosh Shilimkar --- include/uapi/linux/rds.h | 1 + net/rds/ib.c | 1 + 2 files changed, 2 insertions(+) diff --git a/include/uapi/linux/rds.h b/include/uapi/linux/rds.h index 3833113..410ae3c 100644 ---

[net-next][PATCH v2 18/18] RDS: IB: add missing connection cache usage info

rds-tools already support it. Signed-off-by: Santosh Shilimkar --- include/uapi/linux/rds.h | 1 + net/rds/ib.c | 1 + 2 files changed, 2 insertions(+) diff --git a/include/uapi/linux/rds.h b/include/uapi/linux/rds.h index 3833113..410ae3c 100644 --- a/include/uapi/linux/rds.h +++