Re: [net-next PATCH v3 3/3] net: phy: add support for PHY package MMD read/write

2023-12-05 Thread Andrew Lunn
> Having worked with closed-source systems, especially VxWorks, for many > years (where the header files contain all the documentation), it just > seems strange to embed the documentation in the .c files. The key words here might be closed-source. With such black boxes, you don't have access the

Re: [net-next PATCH v3 3/3] net: phy: add support for PHY package MMD read/write

2023-12-05 Thread Jeff Johnson
On 12/5/2023 10:14 AM, Russell King (Oracle) wrote: > On Tue, Dec 05, 2023 at 09:44:05AM -0800, Jeff Johnson wrote: >> So in my experience a function prototype IS the function definition, and >> the actual function is just the implementation of that definition. >> >> But that thinking obviously

Re: [net-next PATCH v3 3/3] net: phy: add support for PHY package MMD read/write

2023-12-05 Thread Russell King (Oracle)
On Tue, Dec 05, 2023 at 09:44:05AM -0800, Jeff Johnson wrote: > On 12/5/2023 8:11 AM, Russell King (Oracle) wrote: > > On Tue, Dec 05, 2023 at 07:29:12AM -0800, Jakub Kicinski wrote: > >> On Tue, 5 Dec 2023 15:10:50 + Russell King (Oracle) wrote: > >>> I've raised this before in other

Re: [net-next PATCH v3 3/3] net: phy: add support for PHY package MMD read/write

2023-12-05 Thread Jeff Johnson
On 12/5/2023 8:11 AM, Russell King (Oracle) wrote: > On Tue, Dec 05, 2023 at 07:29:12AM -0800, Jakub Kicinski wrote: >> On Tue, 5 Dec 2023 15:10:50 + Russell King (Oracle) wrote: >>> I've raised this before in other subsystems, and it's suggested that >>> it's better to have it in the .c file.

Re: [net-next PATCH v3 3/3] net: phy: add support for PHY package MMD read/write

2023-12-05 Thread Russell King (Oracle)
On Tue, Dec 05, 2023 at 07:29:12AM -0800, Jakub Kicinski wrote: > On Tue, 5 Dec 2023 15:10:50 + Russell King (Oracle) wrote: > > I've raised this before in other subsystems, and it's suggested that > > it's better to have it in the .c file. I guess the reason is that it's > > more obvious that

Re: [net-next PATCH v3 3/3] net: phy: add support for PHY package MMD read/write

2023-12-05 Thread Jakub Kicinski
On Tue, 5 Dec 2023 15:10:50 + Russell King (Oracle) wrote: > I've raised this before in other subsystems, and it's suggested that > it's better to have it in the .c file. I guess the reason is that it's > more obvious that the function is documented when modifying it, so > there's a higher