Re: [net-wireless-orinoco] question about potential null pointer dereference

2017-05-30 Thread Johannes Berg
Hi, > The issue here is that line 56 implies that pointer tfm_michael > might be NULL. If this is the case, there is a potential NULL > pointer dereference at line 52 once pointer tfm_michael is > indirectly dereferenced inside macro SHASH_DESC_ON_STACK(). > > My question is if there is any

Re: [net-wireless-orinoco] question about potential null pointer dereference

2017-05-30 Thread Johannes Berg
Hi, > The issue here is that line 56 implies that pointer tfm_michael > might be NULL. If this is the case, there is a potential NULL > pointer dereference at line 52 once pointer tfm_michael is > indirectly dereferenced inside macro SHASH_DESC_ON_STACK(). > > My question is if there is any

[net-wireless-orinoco] question about potential null pointer dereference

2017-05-30 Thread Gustavo A. R. Silva
Hello everybody, While looking into Coverity ID 1357460 I ran into the following piece of code at drivers/net/wireless/intersil/orinoco/mic.c:48 48int orinoco_mic(struct crypto_shash *tfm_michael, u8 *key, 49u8 *da, u8 *sa, u8 priority, 50u8 *data, size_t

[net-wireless-orinoco] question about potential null pointer dereference

2017-05-30 Thread Gustavo A. R. Silva
Hello everybody, While looking into Coverity ID 1357460 I ran into the following piece of code at drivers/net/wireless/intersil/orinoco/mic.c:48 48int orinoco_mic(struct crypto_shash *tfm_michael, u8 *key, 49u8 *da, u8 *sa, u8 priority, 50u8 *data, size_t