Re: [net PATCH] tcp: Mark fastopen SYN packet as lost when receiving ICMP_TOOBIG/ICMP_FRAG_NEEDED

2020-12-11 Thread Yuchung Cheng
On Fri, Dec 11, 2020 at 1:51 PM Alexander Duyck wrote: > > On Fri, Dec 11, 2020 at 11:18 AM Eric Dumazet wrote: > > > > On Fri, Dec 11, 2020 at 6:15 PM Alexander Duyck > > wrote: > > > > > > On Fri, Dec 11, 2020 at 8:22 AM Eric Dumazet wrote: > > > > > > > > On Fri, Dec 11, 2020 at 5:03 PM

Re: [net PATCH] tcp: Mark fastopen SYN packet as lost when receiving ICMP_TOOBIG/ICMP_FRAG_NEEDED

2020-12-11 Thread Alexander Duyck
On Fri, Dec 11, 2020 at 11:18 AM Eric Dumazet wrote: > > On Fri, Dec 11, 2020 at 6:15 PM Alexander Duyck > wrote: > > > > On Fri, Dec 11, 2020 at 8:22 AM Eric Dumazet wrote: > > > > > > On Fri, Dec 11, 2020 at 5:03 PM Alexander Duyck > > > wrote: > > > > > > > That's fine. I can target this

Re: [net PATCH] tcp: Mark fastopen SYN packet as lost when receiving ICMP_TOOBIG/ICMP_FRAG_NEEDED

2020-12-11 Thread Eric Dumazet
On Fri, Dec 11, 2020 at 6:15 PM Alexander Duyck wrote: > > On Fri, Dec 11, 2020 at 8:22 AM Eric Dumazet wrote: > > > > On Fri, Dec 11, 2020 at 5:03 PM Alexander Duyck > > wrote: > > > > > That's fine. I can target this for net-next. I had just selected net > > > since I had considered it a fix,

Re: [net PATCH] tcp: Mark fastopen SYN packet as lost when receiving ICMP_TOOBIG/ICMP_FRAG_NEEDED

2020-12-11 Thread Alexander Duyck
On Fri, Dec 11, 2020 at 8:22 AM Eric Dumazet wrote: > > On Fri, Dec 11, 2020 at 5:03 PM Alexander Duyck > wrote: > > > That's fine. I can target this for net-next. I had just selected net > > since I had considered it a fix, but I suppose it could be considered > > a behavioral change. > > We

Re: [net PATCH] tcp: Mark fastopen SYN packet as lost when receiving ICMP_TOOBIG/ICMP_FRAG_NEEDED

2020-12-11 Thread Eric Dumazet
On Fri, Dec 11, 2020 at 5:03 PM Alexander Duyck wrote: > That's fine. I can target this for net-next. I had just selected net > since I had considered it a fix, but I suppose it could be considered > a behavioral change. We are very late in the 5.10 cycle, and we never handled ICMP in this

Re: [net PATCH] tcp: Mark fastopen SYN packet as lost when receiving ICMP_TOOBIG/ICMP_FRAG_NEEDED

2020-12-11 Thread Alexander Duyck
On Thu, Dec 10, 2020 at 10:24 PM Eric Dumazet wrote: > > On Fri, Dec 11, 2020 at 2:55 AM Alexander Duyck > wrote: > > > > From: Alexander Duyck > > > > In the case of a fastopen SYN there are cases where it may trigger either a > > ICMP_TOOBIG message in the case of IPv6 or a fragmentation

Re: [net PATCH] tcp: Mark fastopen SYN packet as lost when receiving ICMP_TOOBIG/ICMP_FRAG_NEEDED

2020-12-11 Thread kernel test robot
Hi Alexander, Thank you for the patch! Yet something to improve: [auto build test ERROR on net/master] url: https://github.com/0day-ci/linux/commits/Alexander-Duyck/tcp-Mark-fastopen-SYN-packet-as-lost-when-receiving-ICMP_TOOBIG-ICMP_FRAG_NEEDED/20201211-100032 base:

Re: [net PATCH] tcp: Mark fastopen SYN packet as lost when receiving ICMP_TOOBIG/ICMP_FRAG_NEEDED

2020-12-10 Thread Eric Dumazet
On Fri, Dec 11, 2020 at 2:55 AM Alexander Duyck wrote: > > From: Alexander Duyck > > In the case of a fastopen SYN there are cases where it may trigger either a > ICMP_TOOBIG message in the case of IPv6 or a fragmentation request in the > case of IPv4. This results in the socket stalling for a

[net PATCH] tcp: Mark fastopen SYN packet as lost when receiving ICMP_TOOBIG/ICMP_FRAG_NEEDED

2020-12-10 Thread Alexander Duyck
From: Alexander Duyck In the case of a fastopen SYN there are cases where it may trigger either a ICMP_TOOBIG message in the case of IPv6 or a fragmentation request in the case of IPv4. This results in the socket stalling for a second or more as it does not respond to the message by