Re: [net PATCH v3 1/3] net: netprio: fix files lock and remove useless d_path bits

2012-08-16 Thread David Miller
From: John Fastabend Date: Tue, 14 Aug 2012 15:34:24 -0700 > Add lock to prevent a race with a file closing and also remove > useless and ugly sscanf code. The extra code was never needed > and the case it supposedly protected against is in fact handled > correctly by sock_from_file as pointed

Re: [net PATCH v3 1/3] net: netprio: fix files lock and remove useless d_path bits

2012-08-16 Thread David Miller
From: John Fastabend john.r.fastab...@intel.com Date: Tue, 14 Aug 2012 15:34:24 -0700 Add lock to prevent a race with a file closing and also remove useless and ugly sscanf code. The extra code was never needed and the case it supposedly protected against is in fact handled correctly by

Re: [net PATCH v3 1/3] net: netprio: fix files lock and remove useless d_path bits

2012-08-15 Thread Al Viro
On Wed, Aug 15, 2012 at 06:52:06AM -0400, Neil Horman wrote: > On Tue, Aug 14, 2012 at 03:34:24PM -0700, John Fastabend wrote: > > Add lock to prevent a race with a file closing and also remove > > useless and ugly sscanf code. The extra code was never needed > > and the case it supposedly

Re: [net PATCH v3 1/3] net: netprio: fix files lock and remove useless d_path bits

2012-08-15 Thread Neil Horman
On Tue, Aug 14, 2012 at 03:34:24PM -0700, John Fastabend wrote: > Add lock to prevent a race with a file closing and also remove > useless and ugly sscanf code. The extra code was never needed > and the case it supposedly protected against is in fact handled > correctly by sock_from_file as

Re: [net PATCH v3 1/3] net: netprio: fix files lock and remove useless d_path bits

2012-08-15 Thread Neil Horman
On Tue, Aug 14, 2012 at 03:34:24PM -0700, John Fastabend wrote: Add lock to prevent a race with a file closing and also remove useless and ugly sscanf code. The extra code was never needed and the case it supposedly protected against is in fact handled correctly by sock_from_file as pointed

Re: [net PATCH v3 1/3] net: netprio: fix files lock and remove useless d_path bits

2012-08-15 Thread Al Viro
On Wed, Aug 15, 2012 at 06:52:06AM -0400, Neil Horman wrote: On Tue, Aug 14, 2012 at 03:34:24PM -0700, John Fastabend wrote: Add lock to prevent a race with a file closing and also remove useless and ugly sscanf code. The extra code was never needed and the case it supposedly protected

[net PATCH v3 1/3] net: netprio: fix files lock and remove useless d_path bits

2012-08-14 Thread John Fastabend
Add lock to prevent a race with a file closing and also remove useless and ugly sscanf code. The extra code was never needed and the case it supposedly protected against is in fact handled correctly by sock_from_file as pointed out by Al Viro. CC: Neil Horman Reported-by: Al Viro Signed-off-by:

[net PATCH v3 1/3] net: netprio: fix files lock and remove useless d_path bits

2012-08-14 Thread John Fastabend
Add lock to prevent a race with a file closing and also remove useless and ugly sscanf code. The extra code was never needed and the case it supposedly protected against is in fact handled correctly by sock_from_file as pointed out by Al Viro. CC: Neil Horman nhor...@tuxdriver.com Reported-by: Al