Re: [ofa-general] Re: Merging of completely unreviewed drivers

2008-02-22 Thread Al Viro
On Fri, Feb 22, 2008 at 11:59:35PM +0100, Krzysztof Halasa wrote: > Sure - because email is not C code. > > Actually you don't "read" C code, word by word, as you read books - do > you? If it's decently written - sure, why not? Unfortunately, more common case is somewhere between the writing on

Re: [ofa-general] Re: Merging of completely unreviewed drivers

2008-02-22 Thread Krzysztof Halasa
Peter Zijlstra <[EMAIL PROTECTED]> writes: > So, yes, I have the screen estate for very long lines, but I find that > long lines require more effort to read (that very much includes leading > whitespace). Also, since long lines are rare (and they should be, if you > nest too deep you have other is

Re: [ofa-general] Re: Merging of completely unreviewed drivers

2008-02-22 Thread Bart Van Assche
On Fri, Feb 22, 2008 at 7:54 PM, Ingo Molnar <[EMAIL PROTECTED]> wrote: > If a patch or if a file has a clean _style_, bugs and deeper > structural problems often stand out like a sore thumb. But if the > code is peppered with random style noise, it's a lot harder (for me > at least

Re: [ofa-general] Re: Merging of completely unreviewed drivers

2008-02-22 Thread John W. Linville
On Fri, Feb 22, 2008 at 04:17:17PM +0100, Peter Zijlstra wrote: > Even with e-mail, I can easily show over 200 characters wide with a > large font (say 11pt) but find it harder to read emails that don't > nicely wrap at 78. So much so that I often find myself not reading the > mail, or restyling i

Re: [ofa-general] Re: Merging of completely unreviewed drivers

2008-02-22 Thread John W. Linville
On Sat, Feb 23, 2008 at 12:55:03AM +1030, David Newall wrote: > Bart Van Assche wrote: > > There is a reason to limit line length: scientific research has shown > > that readability of regular texts is optimal for a line length between > > 55 and 65 characters. > > Putting aside the point that we'

Re: [ofa-general] Re: Merging of completely unreviewed drivers

2008-02-22 Thread Peter Zijlstra
On Sat, 2008-02-23 at 00:55 +1030, David Newall wrote: > Bart Van Assche wrote: > > There is a reason to limit line length: scientific research has shown > > that readability of regular texts is optimal for a line length between > > 55 and 65 characters. > > Putting aside the point that we're tal

Re: [ofa-general] Re: Merging of completely unreviewed drivers

2008-02-22 Thread David Newall
Bart Van Assche wrote: > There is a reason to limit line length: scientific research has shown > that readability of regular texts is optimal for a line length between > 55 and 65 characters. Putting aside the point that we're talking code, not regular text, I've heard that said before and I don't

Re: [ofa-general] Re: Merging of completely unreviewed drivers

2008-02-22 Thread Bart Van Assche
On Fri, Feb 22, 2008 at 2:46 AM, David Newall <[EMAIL PROTECTED]> wrote: > Krzysztof Halasa wrote: > > Perhaps we should increase line length limit, 132 should be fine. > > Especially useful with long printk() lines and long arithmetic > > expressions. > > Yes; or even longer. 80 characters mi

Re: [ofa-general] Re: Merging of completely unreviewed drivers

2008-02-22 Thread Adrian Bunk
On Thu, Feb 21, 2008 at 10:29:09PM -0800, Junio C Hamano wrote: > Linus Torvalds <[EMAIL PROTECTED]> writes: > > > So I'd be happier with warnings about deep indentation (but how do you > > count it? Will people then try to fake things out by using 4-space indents > > and then "deep" indentation

Re: [ofa-general] Re: Merging of completely unreviewed drivers

2008-02-21 Thread Junio C Hamano
Linus Torvalds <[EMAIL PROTECTED]> writes: > So I'd be happier with warnings about deep indentation (but how do you > count it? Will people then try to fake things out by using 4-space indents > and then "deep" indentations will look like just a couple of tabs?) and > against complex expression