Re: [patch, try#2] kvm: fix GFP_KERNEL allocation in atomic section in kvm_dev_ioctl_create_vcpu()

2006-12-28 Thread Avi Kivity
Ingo Molnar wrote: I've got a security related question as well: vcpu_load() sets up a physical CPU's VM registers/state, and vcpu_put() drops that. But vcpu_put() only does a put_cpu() call - it does not tear down any VM state that has been loaded into the CPU. Is it guaranteed that (hostile)

Re: [patch, try#2] kvm: fix GFP_KERNEL allocation in atomic section in kvm_dev_ioctl_create_vcpu()

2006-12-28 Thread Ingo Molnar
* Avi Kivity <[EMAIL PROTECTED]> wrote: > Ingo Molnar wrote: > >Subject: [patch] kvm: fix GFP_KERNEL allocation in atomic section in > >kvm_dev_ioctl_create_vcpu() > >From: Ingo Molnar <[EMAIL PROTECTED]> > > > >fix an GFP_KERNEL allocation in atomic section: > >kvm_dev_ioctl_create_vcpu() call

Re: [patch, try#2] kvm: fix GFP_KERNEL allocation in atomic section in kvm_dev_ioctl_create_vcpu()

2006-12-28 Thread Avi Kivity
Ingo Molnar wrote: Subject: [patch] kvm: fix GFP_KERNEL allocation in atomic section in kvm_dev_ioctl_create_vcpu() From: Ingo Molnar <[EMAIL PROTECTED]> fix an GFP_KERNEL allocation in atomic section: kvm_dev_ioctl_create_vcpu() called kvm_mmu_init(), which calls alloc_pages(), while holding

[patch, try#2] kvm: fix GFP_KERNEL allocation in atomic section in kvm_dev_ioctl_create_vcpu()

2006-12-28 Thread Ingo Molnar
* Ingo Molnar <[EMAIL PROTECTED]> wrote: > > Yes it does. It calls nonpaging_init_context() which calls > > vmx_set_cr3() which promptly trashes address space of the VM that > > previously ran on that vcpu (or, if there were none, logs a vmwrite > > error). > > ok, i missed that. Nevertheles