Re: [patch/rfc 2/4] pcf857x I2C GPIO expander driver

2007-12-06 Thread David Brownell
On Thursday 06 December 2007, Jean Delvare wrote: > Also, I don't quite see what > is supposed to make compatibility with the legacy drivers easier, nor > how, not why it matters in the first place. There's a clear either/or disjunction. No fuzzy/confusing middle ground. > > +static int

Re: [patch/rfc 2/4] pcf857x I2C GPIO expander driver

2007-12-06 Thread Jean Delvare
Hi David, On Wed, 5 Dec 2007 19:03:12 -0800, David Brownell wrote: > On Friday 30 November 2007, David Brownell wrote: > > Thanks for the review.  I'll snip out typos and similar trivial > > comments (and fix them!), using responses here for more the > > substantive feedback. > > Here's the

Re: [patch/rfc 2/4] pcf857x I2C GPIO expander driver

2007-12-06 Thread Jean Delvare
Hi David, On Wed, 5 Dec 2007 19:03:12 -0800, David Brownell wrote: On Friday 30 November 2007, David Brownell wrote: Thanks for the review.  I'll snip out typos and similar trivial comments (and fix them!), using responses here for more the substantive feedback. Here's the current

Re: [patch/rfc 2/4] pcf857x I2C GPIO expander driver

2007-12-06 Thread David Brownell
On Thursday 06 December 2007, Jean Delvare wrote: Also, I don't quite see what is supposed to make compatibility with the legacy drivers easier, nor how, not why it matters in the first place. There's a clear either/or disjunction. No fuzzy/confusing middle ground. +static int

Re: [patch/rfc 2/4] pcf857x I2C GPIO expander driver

2007-12-05 Thread David Brownell
On Friday 30 November 2007, David Brownell wrote: > Thanks for the review.  I'll snip out typos and similar trivial > comments (and fix them!), using responses here for more the > substantive feedback. Here's the current version of this patch ... updated to put the driver into drivers/gpio

Re: [patch/rfc 2/4] pcf857x I2C GPIO expander driver

2007-12-05 Thread David Brownell
On Friday 30 November 2007, David Brownell wrote: Thanks for the review.  I'll snip out typos and similar trivial comments (and fix them!), using responses here for more the substantive feedback. Here's the current version of this patch ... updated to put the driver into drivers/gpio (separate