Re: [patch] (2nd try) add epoll compat code to kernel/compat.c ...

2007-02-13 Thread Stephen Rothwell
On Tue, 13 Feb 2007 08:43:05 -0600 James Bottomley <[EMAIL PROTECTED]> wrote: > > Not for parisc at the instruction level. In narrow mode (32 bit mode), > a u64 load has to be done by two 32 bit loads which gives it a 4 byte > alignment requirement. In wide mode (64 bit mode) the 64 bit load >

Re: [patch] (2nd try) add epoll compat code to kernel/compat.c ...

2007-02-13 Thread James Bottomley
On Tue, 2007-02-13 at 15:35 +1100, Stephen Rothwell wrote: > OK, I have thought about this some more and I *think* the only > architecture that needs compat_sys_epoll_ctl or compat_sys_epoll_wait is > ia64 where the 64 bit version of struct epoll_event is different from the > 32 bit version. On

Re: [patch] (2nd try) add epoll compat code to kernel/compat.c ...

2007-02-13 Thread Stephen Rothwell
On Mon, 12 Feb 2007 23:26:42 -0800 (PST) Davide Libenzi wrote: > > ARM-OABI also defines them, dunno why. Rmk? I suspect that OABI stands for old ABI and the alignment of 64 bit quantities changed at some point. I am pretty sure that arm is only 32bit, but I assume that they need backward

Re: [patch] (2nd try) add epoll compat code to kernel/compat.c ...

2007-02-13 Thread Stephen Rothwell
On Mon, 12 Feb 2007 23:26:42 -0800 (PST) Davide Libenzi davidel@xmailserver.org wrote: ARM-OABI also defines them, dunno why. Rmk? I suspect that OABI stands for old ABI and the alignment of 64 bit quantities changed at some point. I am pretty sure that arm is only 32bit, but I assume that

Re: [patch] (2nd try) add epoll compat code to kernel/compat.c ...

2007-02-13 Thread James Bottomley
On Tue, 2007-02-13 at 15:35 +1100, Stephen Rothwell wrote: OK, I have thought about this some more and I *think* the only architecture that needs compat_sys_epoll_ctl or compat_sys_epoll_wait is ia64 where the 64 bit version of struct epoll_event is different from the 32 bit version. On

Re: [patch] (2nd try) add epoll compat code to kernel/compat.c ...

2007-02-13 Thread Stephen Rothwell
On Tue, 13 Feb 2007 08:43:05 -0600 James Bottomley [EMAIL PROTECTED] wrote: Not for parisc at the instruction level. In narrow mode (32 bit mode), a u64 load has to be done by two 32 bit loads which gives it a 4 byte alignment requirement. In wide mode (64 bit mode) the 64 bit load

Re: [patch] (2nd try) add epoll compat code to kernel/compat.c ...

2007-02-12 Thread Davide Libenzi
On Tue, 13 Feb 2007, Stephen Rothwell wrote: > A better way here might be to have each 64 bit architecture define > compat_epoll_event in its asm/compat.h and then you can just use: > > if (copy_from_user(, event, sizeof(user))) > return -EFAULT; > kernel =

Re: [patch] (2nd try) add epoll compat code to kernel/compat.c ...

2007-02-12 Thread Stephen Rothwell
Hi Davide, [Linux-arch readers can skip to the last few paragraphs ...] Just a couple of nits to start: On Sun, 11 Feb 2007 16:24:30 -0800 (PST) Davide Libenzi wrote: > > diff -Nru linux-2.6.20/fs/eventpoll.c linux-2.6.20.mod/fs/eventpoll.c > --- linux-2.6.20/fs/eventpoll.c 2007-02-04

Re: [patch] (2nd try) add epoll compat code to kernel/compat.c ...

2007-02-12 Thread Stephen Rothwell
Hi Davide, [Linux-arch readers can skip to the last few paragraphs ...] Just a couple of nits to start: On Sun, 11 Feb 2007 16:24:30 -0800 (PST) Davide Libenzi davidel@xmailserver.org wrote: diff -Nru linux-2.6.20/fs/eventpoll.c linux-2.6.20.mod/fs/eventpoll.c ---

Re: [patch] (2nd try) add epoll compat code to kernel/compat.c ...

2007-02-12 Thread Davide Libenzi
On Tue, 13 Feb 2007, Stephen Rothwell wrote: A better way here might be to have each 64 bit architecture define compat_epoll_event in its asm/compat.h and then you can just use: if (copy_from_user(user, event, sizeof(user))) return -EFAULT; kernel =

[patch] (2nd try) add epoll compat code to kernel/compat.c ...

2007-02-11 Thread Davide Libenzi
Add epoll compat_ code to kernel/compat.c. IA64 and ARM-OABI are currently using their own version of epoll compat_ code and they could probably wire to the new common code. Unfortunately, sys_epoll_pwait needs two compat versions, one for sigset_t only, and one for sigset_t+epoll_event.

[patch] (2nd try) add epoll compat code to kernel/compat.c ...

2007-02-11 Thread Davide Libenzi
Add epoll compat_ code to kernel/compat.c. IA64 and ARM-OABI are currently using their own version of epoll compat_ code and they could probably wire to the new common code. Unfortunately, sys_epoll_pwait needs two compat versions, one for sigset_t only, and one for sigset_t+epoll_event.