Re: [patch] 2.4 version of my duplicate IP and MAC detection patch

2000-10-18 Thread James Sutherland
On Tue, 17 Oct 2000, Werner Almesberger wrote: > Marc MERLIN wrote: > > Come on, Andi, it's not. You do DAD, you get your IP, I plug my laptop, use > > your IP, you don't even know it. My patch lets you know. > > The reason I wrote it is that I've seen this happen too many times already. > >

Re: [patch] 2.4 version of my duplicate IP and MAC detection patch

2000-10-18 Thread James Sutherland
On Tue, 17 Oct 2000, Werner Almesberger wrote: Marc MERLIN wrote: Come on, Andi, it's not. You do DAD, you get your IP, I plug my laptop, use your IP, you don't even know it. My patch lets you know. The reason I wrote it is that I've seen this happen too many times already. Also, if

Re: [patch] 2.4 version of my duplicate IP and MAC detection patch

2000-10-17 Thread Werner Almesberger
Marc MERLIN wrote: > Come on, Andi, it's not. You do DAD, you get your IP, I plug my laptop, use > your IP, you don't even know it. My patch lets you know. > The reason I wrote it is that I've seen this happen too many times already. Also, if the network is not operational at the time you

Re: [patch] 2.4 version of my duplicate IP and MAC detection patch

2000-10-17 Thread Werner Almesberger
Marc MERLIN wrote: Come on, Andi, it's not. You do DAD, you get your IP, I plug my laptop, use your IP, you don't even know it. My patch lets you know. The reason I wrote it is that I've seen this happen too many times already. Also, if the network is not operational at the time you configure

Re: [patch] 2.4 version of my duplicate IP and MAC detection patch

2000-09-27 Thread Marc MERLIN
On Sat, Sep 23, 2000 at 02:02:24PM +, Julian Anastasov wrote: > > I didn't receive any negative comments, except for Alexey who believed the > > check should be done in user space. > > Now you receive another negative comment, for the 2.2 version :) Thanks for the feedback, it is

Re: [patch] 2.4 version of my duplicate IP and MAC detection patch

2000-09-23 Thread Julian Anastasov
Hello, On Thu, 21 Sep 2000, Marc MERLIN wrote: > I didn't receive any negative comments, except for Alexey who believed the > check should be done in user space. Now you receive another negative comment, for the 2.2 version :) You claim that it is not possible two

Re: [patch] 2.4 version of my duplicate IP and MAC detection patch

2000-09-23 Thread Julian Anastasov
Hello, On Thu, 21 Sep 2000, Marc MERLIN wrote: I didn't receive any negative comments, except for Alexey who believed the check should be done in user space. Now you receive another negative comment, for the 2.2 version :) You claim that it is not possible two

Re: [patch] 2.4 version of my duplicate IP and MAC detection patch

2000-09-22 Thread Marc MERLIN
On Fri, Sep 22, 2000 at 01:25:54AM -0700, David S. Miller wrote: > You've made the foo-address to ascii string routines non-reentrant. > The hbuffer[] was on the local stack for a very good reason. You are right, fixed. http://marc.merlins.org/linux/arppatch/arp-patch-2.4_v1.3 (that part of the

Re: [patch] 2.4 version of my duplicate IP and MAC detection patch

2000-09-22 Thread David S. Miller
Date: Fri, 22 Sep 2000 13:19:30 +0200 From: "Andi Kleen" <[EMAIL PROTECTED]> That already exists in form of a packet socket bound to the ARP IEEE protocol. Marc is probably right though that running an arp daemon all the time just for that would be a bit of overkill though.

Re: [patch] 2.4 version of my duplicate IP and MAC detection patch

2000-09-22 Thread Andi Kleen
On Fri, Sep 22, 2000 at 01:25:54AM -0700, David S. Miller wrote: > I don't like this change at all, I think it can be done completely > in user space. The existence of a working tcpdump is proof of this > fact. :-) Whether it can be done efficiently is another issue. I agree. I think DAD once

Re: [patch] 2.4 version of my duplicate IP and MAC detection patch

2000-09-22 Thread David S. Miller
You've made the foo-address to ascii string routines non-reentrant. The hbuffer[] was on the local stack for a very good reason. Why can't you write a userspace daemon that listens on one of the lower level raw'ish sockets for arp packets and do the same checks there. I don't like this change

Re: [patch] 2.4 version of my duplicate IP and MAC detection patch

2000-09-22 Thread David S. Miller
You've made the foo-address to ascii string routines non-reentrant. The hbuffer[] was on the local stack for a very good reason. Why can't you write a userspace daemon that listens on one of the lower level raw'ish sockets for arp packets and do the same checks there. I don't like this change

Re: [patch] 2.4 version of my duplicate IP and MAC detection patch

2000-09-22 Thread David S. Miller
Date: Fri, 22 Sep 2000 13:19:30 +0200 From: "Andi Kleen" [EMAIL PROTECTED] That already exists in form of a packet socket bound to the ARP IEEE protocol. Marc is probably right though that running an arp daemon all the time just for that would be a bit of overkill though. Then

Re: [patch] 2.4 version of my duplicate IP and MAC detection patch

2000-09-22 Thread Marc MERLIN
On Fri, Sep 22, 2000 at 01:25:54AM -0700, David S. Miller wrote: You've made the foo-address to ascii string routines non-reentrant. The hbuffer[] was on the local stack for a very good reason. You are right, fixed. http://marc.merlins.org/linux/arppatch/arp-patch-2.4_v1.3 (that part of the

Re: [patch] 2.4 version of my duplicate IP and MAC detection patch

2000-09-21 Thread Marc MERLIN
On Fri, Sep 22, 2000 at 01:31:06AM +0200, Andi Kleen wrote: > You added a linear IP search to fast path ARP processing. The people running > thousands of IP aliases will surely love you. You could at least use the > ip_route_input output instead that arp_rcv computes anyways and check > for

Re: [patch] 2.4 version of my duplicate IP and MAC detection patch

2000-09-21 Thread Andi Kleen
On Thu, Sep 21, 2000 at 04:09:41PM -0700, Marc MERLIN wrote: > I updated my duplicate IP detection patch to work with 2.4. > > I announced the 2.2 version here last year, and several people expressed > interest in it, but it never made it into the kernel unfortunately. I asked > a few times

[patch] 2.4 version of my duplicate IP and MAC detection patch

2000-09-21 Thread Marc MERLIN
I updated my duplicate IP detection patch to work with 2.4. I announced the 2.2 version here last year, and several people expr= essed interest in it, but it never made it into the kernel unfortunately. I = asked a few times and eventually gave up as I didn't want to appear overly = pushy

[patch] 2.4 version of my duplicate IP and MAC detection patch

2000-09-21 Thread Marc MERLIN
I updated my duplicate IP detection patch to work with 2.4. I announced the 2.2 version here last year, and several people expr= essed interest in it, but it never made it into the kernel unfortunately. I = asked a few times and eventually gave up as I didn't want to appear overly = pushy

Re: [patch] 2.4 version of my duplicate IP and MAC detection patch

2000-09-21 Thread Andi Kleen
On Thu, Sep 21, 2000 at 04:09:41PM -0700, Marc MERLIN wrote: I updated my duplicate IP detection patch to work with 2.4. I announced the 2.2 version here last year, and several people expressed interest in it, but it never made it into the kernel unfortunately. I asked a few times and

Re: [patch] 2.4 version of my duplicate IP and MAC detection patch

2000-09-21 Thread Marc MERLIN
On Fri, Sep 22, 2000 at 01:31:06AM +0200, Andi Kleen wrote: You added a linear IP search to fast path ARP processing. The people running thousands of IP aliases will surely love you. You could at least use the ip_route_input output instead that arp_rcv computes anyways and check for