Re: [patch] 2.4.0-test8: Alpha RTC clean-ups

2000-09-25 Thread Ralf Baechle
Reply #2 - the list's name changed to [EMAIL PROTECTED]; [EMAIL PROTECTED] is now bouncing. Ralf - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] Please read the FAQ at http://www.tux.org/lkml/

Re: [patch] 2.4.0-test8: Alpha RTC clean-ups

2000-09-25 Thread Ralf Baechle
On Mon, Sep 25, 2000 at 12:50:06PM +0200, Jan-Benedict Glaw wrote: > On Mon, Sep 25, 2000 at 11:35:35AM +0200, Maciej W. Rozycki wrote: > > On Fri, 22 Sep 2000, Jan-Benedict Glaw wrote: > > > > > Instead of having hard-coded values, we should maybe do something > > > more variable like: > > >

Re: [patch] 2.4.0-test8: Alpha RTC clean-ups

2000-09-25 Thread Maciej W. Rozycki
On Mon, 25 Sep 2000, Jan-Benedict Glaw wrote: > ./driver/char/rtc.c:rtc_init() > #if defined(__alpha__) || defined(__mips__) > [...] That is wrong. I fixed this partially in the MIPS/Linux CVS tree a few weeks ago. The __mips__ conditional is to be completely removed. > MIPS does that as

Re: [patch] 2.4.0-test8: Alpha RTC clean-ups

2000-09-25 Thread Jan-Benedict Glaw
On Mon, Sep 25, 2000 at 11:35:35AM +0200, Maciej W. Rozycki wrote: > On Fri, 22 Sep 2000, Jan-Benedict Glaw wrote: > > > Instead of having hard-coded values, we should maybe do something > > more variable like: > > if (year >= (20 + YEARS_SINCE_2000) && year < (48 + YEARS_SINCE_2000) > >

Re: [patch] 2.4.0-test8: Alpha RTC clean-ups

2000-09-25 Thread Maciej W. Rozycki
On Fri, 22 Sep 2000, Jan-Benedict Glaw wrote: > Instead of having hard-coded values, we should maybe do something > more variable like: > if (year >= (20 + YEARS_SINCE_2000) && year < (48 + YEARS_SINCE_2000) > ... This looks reasonable. > YEARS_SINCE_2000 could be define'd through

Re: [patch] 2.4.0-test8: Alpha RTC clean-ups

2000-09-25 Thread Maciej W. Rozycki
On Fri, 22 Sep 2000, Jan-Benedict Glaw wrote: Instead of having hard-coded values, we should maybe do something more variable like: if (year = (20 + YEARS_SINCE_2000) year (48 + YEARS_SINCE_2000) ... This looks reasonable. YEARS_SINCE_2000 could be define'd through

Re: [patch] 2.4.0-test8: Alpha RTC clean-ups

2000-09-25 Thread Jan-Benedict Glaw
On Mon, Sep 25, 2000 at 11:35:35AM +0200, Maciej W. Rozycki wrote: On Fri, 22 Sep 2000, Jan-Benedict Glaw wrote: Instead of having hard-coded values, we should maybe do something more variable like: if (year = (20 + YEARS_SINCE_2000) year (48 + YEARS_SINCE_2000) ... This

Re: [patch] 2.4.0-test8: Alpha RTC clean-ups

2000-09-25 Thread Maciej W. Rozycki
On Mon, 25 Sep 2000, Jan-Benedict Glaw wrote: ./driver/char/rtc.c:rtc_init() #if defined(__alpha__) || defined(__mips__) [...] That is wrong. I fixed this partially in the MIPS/Linux CVS tree a few weeks ago. The __mips__ conditional is to be completely removed. MIPS does that as well

Re: [patch] 2.4.0-test8: Alpha RTC clean-ups

2000-09-25 Thread Ralf Baechle
On Mon, Sep 25, 2000 at 12:50:06PM +0200, Jan-Benedict Glaw wrote: On Mon, Sep 25, 2000 at 11:35:35AM +0200, Maciej W. Rozycki wrote: On Fri, 22 Sep 2000, Jan-Benedict Glaw wrote: Instead of having hard-coded values, we should maybe do something more variable like: if (year = (20

Re: [patch] 2.4.0-test8: Alpha RTC clean-ups

2000-09-25 Thread Ralf Baechle
Reply #2 - the list's name changed to [EMAIL PROTECTED]; [EMAIL PROTECTED] is now bouncing. Ralf - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] Please read the FAQ at http://www.tux.org/lkml/

Re: [patch] 2.4.0-test8: Alpha RTC clean-ups

2000-09-22 Thread Jan-Benedict Glaw
On Fri, Sep 22, 2000 at 08:23:05PM +0200, Maciej W. Rozycki wrote: Hi! > + if (year >= 20 && year < 48) [...] > else if (year >= 48 && year < 70) [...] > - else if (year >= 70 && year < 100) > - /* Digital DECstations, very old... */ > - epoch = 1928;

[patch] 2.4.0-test8: Alpha RTC clean-ups

2000-09-22 Thread Maciej W. Rozycki
Hi, As I already pointed out, there are a few errors in RTC handling for Alpha. Also a few comments are misleading. The following is an updated patch that applies to 2.4.0-test8. Maciej -- + Maciej W. Rozycki, Technical University of Gdansk, Poland +

[patch] 2.4.0-test8: Alpha RTC clean-ups

2000-09-22 Thread Maciej W. Rozycki
Hi, As I already pointed out, there are a few errors in RTC handling for Alpha. Also a few comments are misleading. The following is an updated patch that applies to 2.4.0-test8. Maciej -- + Maciej W. Rozycki, Technical University of Gdansk, Poland +

Re: [patch] 2.4.0-test8: Alpha RTC clean-ups

2000-09-22 Thread Jan-Benedict Glaw
On Fri, Sep 22, 2000 at 08:23:05PM +0200, Maciej W. Rozycki wrote: Hi! + if (year = 20 year 48) [...] else if (year = 48 year 70) [...] - else if (year = 70 year 100) - /* Digital DECstations, very old... */ - epoch = 1928; Instead of having