On Tuesday 13 November 2012 08:44:54 Dan Carpenter wrote:
> I don't think this works as intended. '|' higher precedence than ?: so
> the bitwize OR "0 | (val & STR_MOST)" is a no-op.
>
> I have re-written it to be more clear.
>
> Signed-off-by: Dan Carpenter
> ---
> I don't have a way to test
On Tue, Nov 13, 2012 at 12:03:10AM -0800, Joe Perches wrote:
> On Tue, 2012-11-13 at 10:44 +0300, Dan Carpenter wrote:
> > I don't think this works as intended. '|' higher precedence than ?: so
> > the bitwize OR "0 | (val & STR_MOST)" is a no-op.
> >
> > I have re-written it to be more clear.
>
On Tue, Nov 13, 2012 at 12:03:10AM -0800, Joe Perches wrote:
On Tue, 2012-11-13 at 10:44 +0300, Dan Carpenter wrote:
I don't think this works as intended. '|' higher precedence than ?: so
the bitwize OR 0 | (val STR_MOST) is a no-op.
I have re-written it to be more clear.
[]
diff
On Tuesday 13 November 2012 08:44:54 Dan Carpenter wrote:
I don't think this works as intended. '|' higher precedence than ?: so
the bitwize OR 0 | (val STR_MOST) is a no-op.
I have re-written it to be more clear.
Signed-off-by: Dan Carpenter dan.carpen...@oracle.com
---
I don't have a
On Tue, 2012-11-13 at 10:44 +0300, Dan Carpenter wrote:
> I don't think this works as intended. '|' higher precedence than ?: so
> the bitwize OR "0 | (val & STR_MOST)" is a no-op.
>
> I have re-written it to be more clear.
[]
> diff --git a/sound/pci/es1968.c b/sound/pci/es1968.c
[]
> @@
On Tue, 2012-11-13 at 10:44 +0300, Dan Carpenter wrote:
I don't think this works as intended. '|' higher precedence than ?: so
the bitwize OR 0 | (val STR_MOST) is a no-op.
I have re-written it to be more clear.
[]
diff --git a/sound/pci/es1968.c b/sound/pci/es1968.c
[]
@@ -2581,9
At Tue, 13 Nov 2012 10:44:54 +0300,
Dan Carpenter wrote:
>
> I don't think this works as intended. '|' higher precedence than ?: so
> the bitwize OR "0 | (val & STR_MOST)" is a no-op.
>
> I have re-written it to be more clear.
>
> Signed-off-by: Dan Carpenter
Thanks, applied now.
Takashi
I don't think this works as intended. '|' higher precedence than ?: so
the bitwize OR "0 | (val & STR_MOST)" is a no-op.
I have re-written it to be more clear.
Signed-off-by: Dan Carpenter
---
I don't have a way to test this.
diff --git a/sound/pci/es1968.c b/sound/pci/es1968.c
index
I don't think this works as intended. '|' higher precedence than ?: so
the bitwize OR 0 | (val STR_MOST) is a no-op.
I have re-written it to be more clear.
Signed-off-by: Dan Carpenter dan.carpen...@oracle.com
---
I don't have a way to test this.
diff --git a/sound/pci/es1968.c
At Tue, 13 Nov 2012 10:44:54 +0300,
Dan Carpenter wrote:
I don't think this works as intended. '|' higher precedence than ?: so
the bitwize OR 0 | (val STR_MOST) is a no-op.
I have re-written it to be more clear.
Signed-off-by: Dan Carpenter dan.carpen...@oracle.com
Thanks, applied
10 matches
Mail list logo