Re: [patch] ASoC: hdac_hdmi: Potential NULL deref in hdac_hdmi_get_spk_alloc()

2016-05-03 Thread Vinod Koul
On Tue, May 03, 2016 at 03:26:39PM +0530, Vinod Koul wrote: > On Tue, May 03, 2016 at 10:42:58AM +0300, Dan Carpenter wrote: > > We intended || here instead of &&. The original code potentially leads > > to a NULL dereference. > > This looks good to me, I will test this and get back Acked-by: Vi

Re: [patch] ASoC: hdac_hdmi: Potential NULL deref in hdac_hdmi_get_spk_alloc()

2016-05-03 Thread Vinod Koul
On Tue, May 03, 2016 at 10:42:58AM +0300, Dan Carpenter wrote: > We intended || here instead of &&. The original code potentially leads > to a NULL dereference. This looks good to me, I will test this and get back > > Fixes: 2889099eb8cd ('ASoC: hdac_hdmi: Register chmap controls and ops') > Si

Re: [patch] ASoC: hdac_hdmi: Potential NULL deref in hdac_hdmi_get_spk_alloc()

2016-05-03 Thread Takashi Sakamoto
On May 03 2016 16:42, Dan Carpenter wrote: > We intended || here instead of &&. The original code potentially leads > to a NULL dereference. > > Fixes: 2889099eb8cd ('ASoC: hdac_hdmi: Register chmap controls and ops') > Signed-off-by: Dan Carpenter Indeed. Reviewd-by: Takashi Sakamoto > diff

[patch] ASoC: hdac_hdmi: Potential NULL deref in hdac_hdmi_get_spk_alloc()

2016-05-03 Thread Dan Carpenter
We intended || here instead of &&. The original code potentially leads to a NULL dereference. Fixes: 2889099eb8cd ('ASoC: hdac_hdmi: Register chmap controls and ops') Signed-off-by: Dan Carpenter diff --git a/sound/soc/codecs/hdac_hdmi.c b/sound/soc/codecs/hdac_hdmi.c index 3043120..7e7ff1b 100